fix(rpc): reject nullifier prefixes that exceed 16 bits - #2589
Open
devorun wants to merge 1 commit into
Open
Conversation
SyncNullifiers accepts prefixes as u32, but the store narrows them with `prefix as u16`, silently truncating an out-of-range value (e.g. 65536 -> 0) and querying a different prefix than the client requested. Reject any prefix greater than u16::MAX with InvalidArgument, alongside the existing prefix_len validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2543.
SyncNullifiersvalidates thatprefix_len == 16but does not validate that each requested prefix fits in 16 bits. The store then narrows prefixes withprefix as u16, which silently truncates an out-of-range value (e.g.65536 -> 0) and queries a different prefix than the client requested.u16::MAXwithInvalidArgument, right after the existingprefix_lencheck, so the request fails before reaching the narrowing cast65536is rejected withInvalidArgument