fix(quick-start): present editable prompt proposals - #541
Open
huyanxius wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
已完整检查 Planner Tool 契约、runtime 终态校验、React 状态桥接，以及 Quick Start 的提案展示、主动填入、编辑后确认和生成交接。实现满足 #533 的关键边界：优化结果不会自动覆盖输入框，填入动作不会触发生成，最终提交使用用户编辑后的非空提示词，且内部 Planner/Tool 错误会转换为用户可理解的提示。
验证通过：5 个定向测试文件共 109 个测试、npm run typecheck、9 个变更文件的 oxlint 与 oxfmt 检查。未发现需要提出的正确性、可靠性或可维护性问题。
Internal planner output was leaking implementation details into the user conversation. Replace assumptions with a user-facing summary and hold generation until the proposed prompt is filled and edited. Keep protocol errors sanitized while preserving explicit user control before generation.
Prompt proposal changes span the planner protocol, runtime handoff, React state, and page interaction. Update focused fixtures and regressions for user-facing summaries, sanitized errors, editable confirmation, and adaptive layout. Protect the explicit fill-before-generate boundary from future regressions.
xyh202131
previously approved these changes
Aug 21, 2026
Latest main added a draft migration regression that still followed the retired automatic prompt insertion. Fill the Agent proposal before advancing the rewrite timer and sending generation. Keep the run-sidecar migration assertions aligned with the user-confirmed flow.
huyanxius
force-pushed
the
fix/533-quick-start-prompt-review
branch
from
August 21, 2026 10:30
ffd7679 to
f5eb1fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本 PR 将 Quick Start 的提示词优化改为“Agent 提案、用户编辑并确认”的显式流程，避免内部协议文案暴露，并把最终生成控制权留给用户。
Why
原流程会把默认假设、Tool 语气和控制步骤直接展示给用户，同时自动覆盖输入框。用户难以区分 Agent 的内部状态与可编辑内容，也不便在生成前修正长提示词。
Changes
Implementation
assumptions改为optimizationSummary，并在 runtime 做严格终态校验。onBeforeDispatch等待页面返回用户最终编辑后的提示词，确认前不调用生成 action。Verification
npm test -- src/pages/quick-start/index.test.tsx src/features/quick-start-agent/planner.protocol.test.ts src/features/quick-start-agent/planner.test.ts src/features/quick-start-agent/react.test.tsx src/features/quick-start-agent/runtime.test.ts：5 个文件、109 个测试通过。npm run build：通过，只有既有 chunk-size warning。npx oxlint <9 changed frontend files>：通过。npx oxfmt --check <9 changed frontend files>：通过。/ai/chat流程：提案展示、主动填入、继续编辑均通过，未在确认前发起生成。Screenshots
Desktop
Scope
Related Issues
Closes #533