Skip to content

feat(lsp): add pull diagnostics and native TypeScript 7#2537

Merged
bajrangCoder merged 2 commits into
mainfrom
feat/lsp-native-typescript-diagnostics
Jul 26, 2026
Merged

feat(lsp): add pull diagnostics and native TypeScript 7#2537
bajrangCoder merged 2 commits into
mainfrom
feat/lsp-native-typescript-diagnostics

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member
  • support pull diagnostics and server requests
  • replace legacy TypeScript server with native TypeScript 7

- support pull diagnostics and server requests
- replace legacy TypeScript server with native TypeScript 7
@greptile-apps

greptile-apps Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds pull-based LSP diagnostics and replaces the legacy TypeScript language server with native TypeScript 7.

  • Schedules diagnostic pulls after the editor’s LSP extensions initialize and when documents change or servers request a refresh.
  • Handles additional server-to-client requests, including workspace configuration and workspace-folder queries.
  • Propagates workspace configuration and launcher log-filtering options through server registration.
  • Updates the JavaScript/TypeScript server definition to install and launch native TypeScript 7.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/cm/lsp/diagnostics.ts Implements pull-diagnostic scheduling, result tracking, retries, refresh handling, and editor-lifecycle synchronization.
src/cm/lsp/clientManager.ts Attaches diagnostic synchronization after the LSP plugin and advertises workspace configuration support.
src/cm/lsp/workspace.ts Schedules pulls on connection and clears per-document pull state when the final view closes.
src/cm/lsp/transport.ts Adds bounded responses for common server requests and forwards diagnostic refreshes to the client.
src/cm/lsp/servers/javascript.ts Replaces typescript-language-server with native TypeScript 7 and supplies its configuration and timeout.
src/cm/lsp/serverLauncher.ts Adds optional launcher-output filtering while preserving bridge readiness detection.

Sequence Diagram

sequenceDiagram
  participant Editor
  participant Client as LSP Client
  participant Server as Language Server
  Editor->>Client: Attach LSP and diagnostics extensions
  Client->>Server: textDocument/didOpen
  Client->>Server: textDocument/diagnostic
  Server-->>Client: Full or unchanged diagnostic report
  Client-->>Editor: Store and display diagnostics
  Server->>Client: workspace/diagnostic/refresh
  Client-->>Server: Success response
  Client->>Server: Pull diagnostics for open files
Loading

Reviews (2): Last reviewed commit: "fix initial diagnostic pull" | Re-trigger Greptile

Comment thread src/cm/lsp/workspace.ts Outdated
@bajrangCoder

This comment was marked as outdated.

@bajrangCoder
bajrangCoder added this pull request to the merge queue Jul 26, 2026
Merged via the queue into main with commit 08c8d40 Jul 26, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant