Skip to content

fix: app icon picker and banner hide on reload - #2867

Draft
deadlyjack wants to merge 2 commits into
mainfrom
fix/app-icon-picker
Draft

fix: app icon picker and banner hide on reload#2867
deadlyjack wants to merge 2 commits into
mainfrom
fix/app-icon-picker

Conversation

@deadlyjack

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness or repository-rule violations.

Summary

  • Routes launcher aliases through a stable native launcher activity.
  • Synchronizes generated Android manifest launcher entries during preparation.
  • Improves loader replacement and dialog layering behavior.
  • Adds complete Android and picker assets for eight new app icons.
  • Expands tests covering native mappings, manifest preparation, selection, and dialog behavior.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Picker[App icon picker] --> Selection[Selection logic]
  Selection --> Plugin[System Cordova plugin]
  Plugin --> Alias[Enable selected activity alias]
  Alias --> Launcher[LauncherActivity]
  Launcher --> Main[MainActivity]
Loading

Comment thread src/dialogs/style.scss
@RohitKushvaha01 RohitKushvaha01 added the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Sep 8, 2026
@github-actions github-actions Bot removed the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Sep 8, 2026
@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Preview Release for this, has been built.

Click here to view that github actions build

@RohitKushvaha01
RohitKushvaha01 marked this pull request as draft September 9, 2026 00:34
@deadlyjack

Copy link
Copy Markdown
Member Author

@greptile review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants