[fix] Build the dev web image from a clean checkout - #7029
Conversation
Commit 1df98eb moved web/oss/scripts/copy-pdf-worker.mjs into web/packages/agenta-entities/scripts, and a later commit removed the script entirely, so web/oss/scripts no longer exists. The dev Dockerfiles and compose files still COPY/mount that directory, so a clean checkout fails to build the dev web image with "failed to compute cache key ... /oss/scripts: not found". Existing checkouts only kept building because the deleted directory was still sitting there untracked. Remove the four stale references. The gh/production Dockerfiles never referenced oss/scripts and are unaffected.
|
@coderabbitai review |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe development Dockerfiles no longer copy ChangesDevelopment scripts removal
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Railway Preview Environment
Updated at 2026-09-22T08:18:38.543Z |
1 participant
Context
A clean checkout of
release/v0.119.1cannot build the dev web image.docker buildfails withfailed to compute cache key ... "/oss/scripts": not found, becauseweb/oss/docker/Dockerfile.devandweb/ee/docker/Dockerfile.devstillCOPY oss/scripts ./oss/scripts, and the OSS and EE dev compose files still bind-mountweb/oss/scripts. That directory does not exist anymore: commit1df98eb83bmovedcopy-pdf-worker.mjsintoweb/packages/agenta-entities/scripts, and a later commit removed the script and the pdfjs worker plumbing entirely. Existing local checkouts kept building only because the deletedweb/oss/scriptsdirectory was still sitting there, untracked, on disk.Changes
Removed the four stale references to
oss/scripts:web/oss/docker/Dockerfile.dev:98web/ee/docker/Dockerfile.dev:101hosting/docker-compose/oss/docker-compose.dev.yml:60hosting/docker-compose/ee/docker-compose.dev.yml:67The gh/production Dockerfiles never referenced
oss/scriptsand are unaffected. I grepped the whole tree foross/scriptsandcopy-pdf-worker(Dockerfiles, compose files, web entrypoint, package.json scripts, GitHub workflows) and found no other stale reference underweb/. The remainingoss/scriptshits are allhosting/railway/oss/scripts/, an unrelated Railway deploy path.Tests / notes
Built both dev web images from a fresh plain-git worktree of this branch (no untracked leftovers to mask the bug):
docker build -f web/oss/docker/Dockerfile.dev web/succeeded.docker build -f web/ee/docker/Dockerfile.dev web/succeeded.Both compose files still parse as valid YAML after the edit. I could not run a full
docker compose configagainst real env values because the dev.env.oss.dev/.env.ee.devfiles are gitignored and not present in a fresh worktree; the plain YAML parse confirms the edit did not break the file structure.