Add method isFromRadDecay(const int id). Checks whether particle resu… - #15470
Merged
Conversation
…lts from radioactive decay in its history.
Collaborator
|
Error while checking build/O2/fullCI_slc9 for f85bd63 at 2026-06-10 21:44: Full log here. |
Collaborator
Contributor
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
sawenzel
approved these changes
Aug 10, 2026
sawenzel
added a commit
to sawenzel/AliceO2
that referenced
this pull request
Aug 10, 2026
The query added in AliceO2Group#15470 gave two wrong answers. Primaries returned true, because mTrackIDtoParticlesEntry is meaningless for them - primaries never enter mParticles - so the lookup landed on an unrelated secondary. Descendants of a radioactive decay returned false, because the `imo > 0` guard skipped buffer entry 0, which after FinishPrimary() is the first secondary of the current primary. Walking trackIDs and stopping at mNumberOfPrimaryParticles removes both, and the method becomes const, binds a reference instead of copying the MCTrack, and drops the two includes MCTrack.h already provides. The new test case fails on all four affected checks without this change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sawenzel
added a commit
to sawenzel/AliceO2
that referenced
this pull request
Aug 10, 2026
The query added in AliceO2Group#15470 gave two wrong answers. Primaries returned true, because mTrackIDtoParticlesEntry is meaningless for them - primaries never enter mParticles - so the lookup landed on an unrelated secondary. Descendants of a radioactive decay returned false, because the `imo > 0` guard skipped buffer entry 0, which after FinishPrimary() is the first secondary of the current primary. Walking trackIDs and stopping at mNumberOfPrimaryParticles removes both, and the method becomes const, binds a reference instead of copying the MCTrack, and drops the two includes MCTrack.h already provides. The new test case fails on all four affected checks without this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add method isFromRadDecay(const int id). Checks whether particle results from radioactive decay in its history.