[PWGLF] Optimisation and linter fixes for spectraTOF - #14947
Merged
Conversation
tonmoySh
commented
Feb 12, 2026
Contributor
- Replaced hard-coded PDG codes with named constants from PhysicsConstant.h
- Replaced the "magic numbers" in the expressions constexpr values
- updated the variable and function names to follow standard naming convention (lowerCamelCase)
- updated the configurable names to follow standard naming convention (lowerCamelCase)
- updated the macro names to follow standard naming convention (SCREAMING_SNAKE_CASE)
- Changed the struct name "tofSpectra" to "SpectraTOF" to follow standard naming convention (UpperCamelCase) as well as to match with the Workflow file name (spectraTOF.cxx)
- other minor optimisations
tonmoySh
requested review from
HorstMa,
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
fmazzasc,
gluparel,
hahassan7,
jpxrk,
maciacco,
mfaggin,
mmazzilli,
mpuccio,
omvazque,
singhra1994,
skundu692,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
February 12, 2026 20:09
Collaborator
|
Error while checking build/O2Physics/o2 for 8bba576 at 2026-02-13 02:18: Full log here. |
maciacco
previously approved these changes
Feb 15, 2026
maciacco
marked this pull request as draft
February 15, 2026 10:17
tonmoySh
force-pushed
the
o2linterErrWarn_fixed
branch
from
February 15, 2026 23:01
8bba576 to
af6bed4
Compare
tonmoySh
marked this pull request as ready for review
February 16, 2026 00:01
maciacco
enabled auto-merge (squash)
February 17, 2026 08:00
maciacco
approved these changes
Feb 17, 2026
comrademarvin
pushed a commit
to comrademarvin/O2Physics
that referenced
this pull request
Mar 16, 2026
hyungjun-lee
pushed a commit
to hyungjun-lee/O2Physics
that referenced
this pull request
Apr 15, 2026
mtorresc15
pushed a commit
to mtorresc15/O2Physics
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.