[PWGHF] Fill the PID table for light nuclie in 3prong creator based on BB calibration - #15034
Merged
Merged
Conversation
github-actions
Bot
changed the title
zhangbiao-phy
force-pushed
the
master
branch
from
February 18, 2026 19:49
de74895 to
c3d0fea
Compare
zhangbiao-phy
added a commit
to zhangbiao-phy/O2Physics
that referenced
this pull request
Feb 18, 2026
[PWGHF] Please consider the following formatting changes to AliceO2Group#15034
zhangbiao-phy
changed the title
zhangbiao-phy
marked this pull request as ready for review
February 19, 2026 06:53
zhangbiao-phy
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano and
vkucera
as code owners
February 19, 2026 06:53
vkucera
marked this pull request as draft
February 19, 2026 07:53
Collaborator
|
Fix the error, please. |
zhangbiao-phy
force-pushed
the
master
branch
from
February 19, 2026 07:57
6c34028 to
7b2cd70
Compare
vkucera
requested changes
Feb 19, 2026
vkucera
marked this pull request as draft
February 19, 2026 10:05
zhangbiao-phy
marked this pull request as ready for review
February 19, 2026 13:07
vkucera
requested changes
Feb 19, 2026
vkucera
marked this pull request as draft
February 19, 2026 13:17
zhangbiao-phy
force-pushed
the
master
branch
from
February 19, 2026 14:22
03e9d8e to
020b1bf
Compare
vkucera
reviewed
Feb 19, 2026
vkucera
reviewed
Feb 20, 2026
vkucera
reviewed
Feb 20, 2026
vkucera
reviewed
Feb 20, 2026
vkucera
marked this pull request as ready for review
February 20, 2026 14:28
vkucera
approved these changes
Feb 20, 2026
vkucera
left a comment
vkucera
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @zhangbiao-phy for addressing my suggestions.
zhangbiao-phy
enabled auto-merge (squash)
February 20, 2026 14:48
alibuild
approved these changes
Feb 20, 2026
alibuild
left a comment
alibuild
left a comment
Collaborator
There was a problem hiding this comment.
Auto-approving on behalf of @zhangbiao-phy.
vkucera
reviewed
Feb 24, 2026
| Configurable<bool> applyTopoConstraint{"applyTopoConstraint", false, "apply origin from PV hypothesis for created candidate, works only in KF mode"}; | ||
| Configurable<bool> applyInvMassConstraint{"applyInvMassConstraint", false, "apply particle type hypothesis to recalculate created candidate's momentum, works only in KF mode"}; | ||
|
|
||
| Configurable<LabeledArray<float>> tpcPidBBParamsLightNuclei{"tpcPidBBParamsLightNuclei", {hf_presel_lightnuclei::BetheBlochParams[0], hf_presel_lightnuclei::NParticleRows, hf_presel_lightnuclei::NBetheBlochParams, hf_presel_lightnuclei::labelsRowsNucleiType, hf_presel_lightnuclei::labelsBetheBlochParams}, "TPC PID Bethe–Bloch parameter configurations for light nuclei (deuteron, triton, helium-3)"}; |
Collaborator
There was a problem hiding this comment.
You did not include header that provides LabeledArray.
vkucera
reviewed
Feb 24, 2026
| template <typename TrackType> | ||
| float getNSigmaTpcLightNucleiBetheBloch(const TrackType& track, | ||
| HfProngSpecies species, | ||
| const o2::framework::Configurable<o2::framework::LabeledArray<float>>& bbParams) |
Collaborator
There was a problem hiding this comment.
You did not include the header that provides Configurable and LabeledArray.
comrademarvin
pushed a commit
to comrademarvin/O2Physics
that referenced
this pull request
Mar 16, 2026
hyungjun-lee
pushed a commit
to hyungjun-lee/O2Physics
that referenced
this pull request
Apr 15, 2026
mtorresc15
pushed a commit
to mtorresc15/O2Physics
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no TPC NN calibration for light nuclei, so we need implement the BB calibration by ourself
Tag @fgrosa for informations