[PWGLF] refactor nucleiqc logic, fixed previous errors - #15980
Merged
Conversation
GiorgioAlbertoLucia
requested review from
HorstMa,
abmodak,
alibuild,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
lhusova,
maciacco,
mpuccio,
omvazque,
prottayCMT,
romainschotter,
skundu692 and
smaff92
as code owners
April 27, 2026 14:21
GiorgioAlbertoLucia
marked this pull request as draft
April 27, 2026 14:21
|
O2 linter results: ❌ 5 errors, |
GiorgioAlbertoLucia
marked this pull request as ready for review
April 27, 2026 14:37
Collaborator
|
Error while checking build/O2Physics/o2 for ab9de14 at 2026-04-27 16:54: Full log here. |
vkucera
marked this pull request as draft
April 27, 2026 15:19
Collaborator
|
@GiorgioAlbertoLucia Your PR does not compile on any system. How did you test it? |
vkucera
requested changes
Apr 27, 2026
GiorgioAlbertoLucia
marked this pull request as ready for review
April 27, 2026 15:40
Contributor
Author
Ciao @vkucera, it was building locally (ubuntu 24.04). It looked like the issues were some includes, I probably messed up something in the merge procedure, in fact your changes to the includes were not present in my PR. I reverted to your include version and it still builds locally. Let's see |
vkucera
approved these changes
Apr 27, 2026
maciacco
enabled auto-merge (squash)
April 27, 2026 22:25
maciacco
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.