Skip to content

[PWGCF] Less strict daughter track selection and configurable PID rejection c… - #17389

Merged
EmilGorm merged 4 commits into
AliceO2Group:masterfrom
EmilGorm:master
Aug 10, 2026
Merged

[PWGCF] Less strict daughter track selection and configurable PID rejection c…#17389
EmilGorm merged 4 commits into
AliceO2Group:masterfrom
EmilGorm:master

Conversation

@EmilGorm

Copy link
Copy Markdown
Collaborator

…riteria in flowGenericFramework.cxx

@github-actions github-actions Bot added the pwgcf label Aug 10, 2026
@github-actions github-actions Bot changed the title Less strict daughter track selection and configurable PID rejection c… [PWGCF] Less strict daughter track selection and configurable PID rejection c… Aug 10, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@EmilGorm
EmilGorm marked this pull request as ready for review August 10, 2026 09:21
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 510c7a5 at 2026-08-10 14:52:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 99644d1 at 2026-08-10 15:48:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 0 warnings.'
Found 2 errors and 0 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/fb97d640986dfa1ed581f81fa3159385a03d0ad3/O2Physics-code-check/errors.txt
PWGCF/GenericFramework/Tasks/flowGenericFramework.cxx:2248:89: error: repeated branch body in conditional chain [bugprone-branch-clone,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGenericFramework.cxx:2250:11: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@EmilGorm
EmilGorm enabled auto-merge (squash) August 10, 2026 20:19

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @EmilGorm.

@EmilGorm
EmilGorm merged commit 124d49f into AliceO2Group:master Aug 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants