Skip to content

[PWGCF,PWGHF] Add missing protection in femto dream container in case of HF-V0 combinations - #17429

Merged
fgrosa merged 2 commits into
AliceO2Group:masterfrom
fgrosa:femto
Aug 13, 2026
Merged

[PWGCF,PWGHF] Add missing protection in femto dream container in case of HF-V0 combinations#17429
fgrosa merged 2 commits into
AliceO2Group:masterfrom
fgrosa:femto

Conversation

@fgrosa

@fgrosa fgrosa commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot changed the title Add missing protection in femto dream container in case of HF-V0 combinations [PWGCF,PWGHF] Add missing protection in femto dream container in case of HF-V0 combinations Aug 12, 2026
@github-actions

github-actions Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 32 warnings, 🔕 0 disabled

@fgrosa
fgrosa marked this pull request as ready for review August 12, 2026 12:16
@lauraser
lauraser enabled auto-merge (squash) August 12, 2026 12:51
@alibuild

alibuild commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 53c04e3 at 2026-08-12 22:15:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 29 errors and 1 warnings.'
Found 29 errors and 1 warnings.
++ [[ 29 -gt 0 ]]
++ cat /sw/BUILD/e1ae817973431fe7d0489a0d717be20367874a3f/O2Physics-code-check/errors.txt
PWGCF/FemtoDream/Core/femtoDreamContainer.h:78:30: error: the parameter 'folderName' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:78:54: error: the parameter 'femtoObs' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:111:28: error: the parameter 'folderName' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:111:52: error: the parameter 'femtoObs' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:164:36: error: parameter 'invMassBin' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:185:33: error: the parameter 'folderName' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:185:57: error: the parameter 'femtoObs' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:186:101: error: the parameter 'epObs' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:222:35: error: the parameter 'folderName' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:222:59: error: the parameter 'femtoDKout' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:222:83: error: the parameter 'femtoDKside' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:222:108: error: the parameter 'femtoDKlong' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:229:33: error: the parameter 'folderName' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:229:57: error: the parameter 'femtoDKout' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:229:81: error: the parameter 'femtoDKside' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:229:106: error: the parameter 'femtoDKlong' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:260:35: error: parameter 'qnBins' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:261:40: error: parameter 'pairPhiBins' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:355:11: error: variable 'femtoObs' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:355:21: error: variable 'femtoObsMC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:419:11: error: variable 'femtoObs' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:419:21: error: variable 'femtoObsMC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:463:11: error: variable 'femtoObs' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:463:21: error: variable 'femtoObsMC' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/FemtoDream/Core/femtoDreamContainer.h:613:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGHF/HFC/TableProducer/producerCharmHadronsV0FemtoDream.cxx:215:56: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGHF/HFC/TableProducer/producerCharmHadronsV0FemtoDream.cxx:279:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGHF/HFC/TableProducer/producerCharmHadronsV0FemtoDream.cxx:529:16: error: the variable 'motherparticleMc' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
PWGHF/HFC/TableProducer/producerCharmHadronsV0FemtoDream.cxx:1178:39: error: the parameter 'particles' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/e1ae817973431fe7d0489a0d717be20367874a3f/O2Physics-code-check/warnings.txt
PWGCF/FemtoDream/Core/femtoDreamContainer.h:475:24: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 29 -gt 0 ]]
++ exit 1
--

Full log here.

@fgrosa
fgrosa disabled auto-merge August 13, 2026 07:02
@fgrosa
fgrosa enabled auto-merge (squash) August 13, 2026 07:03
alibuild
alibuild approved these changes Aug 13, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @fgrosa.

@fgrosa
fgrosa merged commit 877668f into AliceO2Group:master Aug 13, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes
@lauraser lauraser lauraser approved these changes
@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner
@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner
@dimihayl dimihayl Awaiting requested review from dimihayl dimihayl is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@dsarkaralice dsarkaralice Awaiting requested review from dsarkaralice dsarkaralice is a code owner
@wrzesaCERN wrzesaCERN Awaiting requested review from wrzesaCERN wrzesaCERN is a code owner

Assignees

No one assigned

Labels

pwgcf pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fgrosa @alibuild @lauraser