Skip to content

[PWGJE] Update code after physics forum - #17432

Open
KotliarovAr wants to merge 8 commits into
AliceO2Group:masterfrom
KotliarovAr:update_after_PhysForum
Open

[PWGJE] Update code after physics forum#17432
KotliarovAr wants to merge 8 commits into
AliceO2Group:masterfrom
KotliarovAr:update_after_PhysForum

Conversation

@KotliarovAr

Copy link
Copy Markdown
Contributor

The main update relates to adding the rho shift in events with TTRef. The rho shift is estimated as the average difference between rho values in events with TTSig and TTRef.

Minor changes:

  • remove unused histograms
  • adjust default values of the configurables

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title [PWGJE]: Update code after physics forum [PWGJE] Update code after physics forum Aug 12, 2026
nzardosh
nzardosh previously approved these changes Aug 12, 2026
@nzardosh
nzardosh self-requested a review August 12, 2026 14:47
@nzardosh

Copy link
Copy Markdown
Collaborator

can you check the megalinter error about shadowed variables please?

@alibuild

alibuild commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d15aefd at 2026-08-13 08:28:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 14 errors and 55 warnings.'
Found 14 errors and 55 warnings.
++ [[ 14 -gt 0 ]]
++ cat /sw/BUILD/11868e2d58156d1cb0eb548ee3a51733069b0363/O2Physics-code-check/errors.txt
PWGJE/Tasks/recoilJets.cxx:101:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:241:23: error: member 'axis' of type 'const AxisObject &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:241:23: error: member 'axis' of type 'const o2::framework::AxisSpec &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:241:23: error: member 'axis' of type 'const o2::framework::Configurable<std::vector<double>, o2::framework::kAxisSpec> &' is a reference [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:289:35: error: member 'eaRhoShifts' of type 'const std::array<EARhoShift, 7>' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:289:48: error: use designated initializer list to initialize 'EARhoShift' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:290:48: error: use designated initializer list to initialize 'EARhoShift' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:291:48: error: use designated initializer list to initialize 'EARhoShift' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:292:48: error: use designated initializer list to initialize 'EARhoShift' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:293:48: error: use designated initializer list to initialize 'EARhoShift' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:294:48: error: use designated initializer list to initialize 'EARhoShift' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:295:48: error: use designated initializer list to initialize 'EARhoShift' [modernize-use-designated-initializers,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:2679:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGJE/Tasks/recoilJets.cxx:2847:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
++ [[ 55 -gt 0 ]]
++ cat /sw/BUILD/11868e2d58156d1cb0eb548ee3a51733069b0363/O2Physics-code-check/warnings.txt
PWGJE/Tasks/recoilJets.cxx:1322:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:1354:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:1455:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:1530:71: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:1618:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:1641:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2373:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2438:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2440:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2460:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2483:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2531:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2586:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2608:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2661:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2691:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2735:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2791:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2813:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2879:38: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2915:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2953:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2957:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:2989:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:3038:35: warning: statement should be inside braces [readability-braces-around-statements]
PWGJE/Tasks/recoilJets.cxx:3084:26: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@nzardosh
nzardosh enabled auto-merge (squash) August 14, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants