Skip to content

[PWGJE] Fix setSingleTrackSelectionBit not setting notBadMcTrack bit - #17435

Merged
nzardosh merged 1 commit into
AliceO2Group:masterfrom
zovarga:fix/subtracted-track-notbadmctrack-bit
Aug 13, 2026
Merged

[PWGJE] Fix setSingleTrackSelectionBit not setting notBadMcTrack bit#17435
nzardosh merged 1 commit into
AliceO2Group:masterfrom
zovarga:fix/subtracted-track-notbadmctrack-bit

Conversation

@zovarga

@zovarga zovarga commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

setTrackSelectionBit defaults setNotBadMcTrack=true, but setSingleTrackSelectionBit (the only bit-builder used for JTrackSub, in eventwiseConstituentSubtractor.cxx) never sets it. Since selectTrack() gates unconditionally on notBadMcTrack, every event-wise constituent-subtracted track fails selection regardless of configured trackSelections, silently zeroing all downstream subtracted-jet finding.

This brings setSingleTrackSelectionBit in line with the existing default behavior of setTrackSelectionBit.

setTrackSelectionBit defaults setNotBadMcTrack=true, but
setSingleTrackSelectionBit (the only bit-builder used for JTrackSub,
in eventwiseConstituentSubtractor.cxx) never sets it. Since
selectTrack() gates unconditionally on notBadMcTrack, every
event-wise constituent-subtracted track fails selection regardless
of configured trackSelections, silently zeroing all downstream
subtracted-jet finding.

This brings setSingleTrackSelectionBit in line with the existing
default behavior of setTrackSelectionBit.
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 3 errors, ⚠️ 3 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix setSingleTrackSelectionBit not setting notBadMcTrack bit [PWGJE] Fix setSingleTrackSelectionBit not setting notBadMcTrack bit Aug 12, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 09bca1e at 2026-08-12 18:11:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 09bca1e at 2026-08-13 10:05:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 10 errors and 0 warnings.'
Found 10 errors and 0 warnings.
++ [[ 10 -gt 0 ]]
++ cat /sw/BUILD/931b55fc3043550e7fa5fb75bec32de8dc55b376/O2Physics-code-check/errors.txt
PWGJE/Core/JetDerivedDataUtilities.h:65:157: error: the parameter 'rctLabel' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGJE/Core/JetDerivedDataUtilities.h:76:7: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGJE/Core/JetDerivedDataUtilities.h:98:94: error: the parameter 'selection' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGJE/Core/JetDerivedDataUtilities.h:307:7: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGJE/Core/JetDerivedDataUtilities.h:327:78: error: the parameter 'trigger' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGJE/Core/JetDerivedDataUtilities.h:507:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGJE/Core/JetDerivedDataUtilities.h:649:12: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGJE/Core/JetDerivedDataUtilities.h:673:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGJE/Core/JetDerivedDataUtilities.h:735:65: error: the const qualified parameter 'clusterDefinitions' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGJE/Core/JetDerivedDataUtilities.h:742:10: error: variable 'end' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 10 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 09bca1e at 2026-08-12 23:18:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@nzardosh
nzardosh merged commit 712ca39 into AliceO2Group:master Aug 13, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants