[PWGJE] Fix setSingleTrackSelectionBit not setting notBadMcTrack bit - #17435
Merged
nzardosh merged 1 commit intoAug 13, 2026
Merged
Conversation
setTrackSelectionBit defaults setNotBadMcTrack=true, but setSingleTrackSelectionBit (the only bit-builder used for JTrackSub, in eventwiseConstituentSubtractor.cxx) never sets it. Since selectTrack() gates unconditionally on notBadMcTrack, every event-wise constituent-subtracted track fails selection regardless of configured trackSelections, silently zeroing all downstream subtracted-jet finding. This brings setSingleTrackSelectionBit in line with the existing default behavior of setTrackSelectionBit.
zovarga
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
August 12, 2026 14:57
|
O2 linter results: ❌ 3 errors, |
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for 09bca1e at 2026-08-13 10:05: Full log here. |
Collaborator
nzardosh
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setTrackSelectionBit defaults setNotBadMcTrack=true, but setSingleTrackSelectionBit (the only bit-builder used for JTrackSub, in eventwiseConstituentSubtractor.cxx) never sets it. Since selectTrack() gates unconditionally on notBadMcTrack, every event-wise constituent-subtracted track fails selection regardless of configured trackSelections, silently zeroing all downstream subtracted-jet finding.
This brings setSingleTrackSelectionBit in line with the existing default behavior of setTrackSelectionBit.