Skip to content

fix: block beta block min and block max are nan on every trial for uniform distribution - #67

Merged
arjunsridhar12345 merged 2 commits into
devfrom
65-fix-block_beta-block_min-and-block_max-are-nan-on-every-trial-for-uniform-distribution
Aug 12, 2026
Merged

fix: block beta block min and block max are nan on every trial for uniform distribution#67
arjunsridhar12345 merged 2 commits into
devfrom
65-fix-block_beta-block_min-and-block_max-are-nan-on-every-trial-for-uniform-distribution

Conversation

@arjunsridhar12345

@arjunsridhar12345 arjunsridhar12345 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Attempts to address #65

@arjunsridhar12345
arjunsridhar12345 marked this pull request as ready for review August 7, 2026 19:16
else ExponentialDistribution(
distribution_parameters=ExponentialDistributionParameters(rate=1.0),
truncation_parameters=TruncationParameters(min=0.0, max=1.0),
def _quiescent_distribution(kind):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe type kind arg

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait this is tests nevermind

@micahwoodard micahwoodard left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

@arjunsridhar12345
arjunsridhar12345 merged commit 824d887 into dev Aug 12, 2026
3 checks passed
@arjunsridhar12345
arjunsridhar12345 deleted the 65-fix-block_beta-block_min-and-block_max-are-nan-on-every-trial-for-uniform-distribution branch August 12, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants