Antalya-26.6 - Fix races in the export_merge_tree_part test family - #2255
Merged
Conversation
…ort_merge_tree_part tests Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
arthurpassos
left a comment
Collaborator
There was a problem hiding this comment.
I swear I thought I had already implemented this. It either got lost during ports or I abandoned this for a reason
…rtition_exports for partitions Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
Collaborator
Author
|
@arthurpassos , I’ve addressed all your comments. Could you please review it again? |
arthurpassos
approved these changes
Aug 24, 2026
arthurpassos
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, assuming CICD is happy with it
| # EXPORT PARTITION runs in the background, so wait for it instead of sleeping. | ||
| # $1 is how many partition exports should have completed by this point, counted from the | ||
| # start of the test (the table keeps one row per export operation). | ||
| function wait_for_partition_exports() |
Collaborator
There was a problem hiding this comment.
Nit: I think it's better if you provide the partition id or transaction id you are waiting for instead of the count.
In any case, I suppose this is good enough for testing code
Collaborator
Author
QA Verification — ✅All four tests changed in this PR passed on every job. The remaining failures are pre-existing and unrelated to this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
CI/CD Options
Exclude tests:
Regression jobs to run: