Skip to content

Antalya-26.6 - Fix races in the export_merge_tree_part test family - #2255

Merged
zvonand merged 2 commits into
antalya-26.6from
ci/antalya-26.6/export-part-wait
Aug 25, 2026
Merged

Antalya-26.6 - Fix races in the export_merge_tree_part test family#2255
zvonand merged 2 commits into
antalya-26.6from
ci/antalya-26.6/export-part-wait

Conversation

@CarlosFelipeOR

@CarlosFelipeOR CarlosFelipeOR commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

…ort_merge_tree_part tests

Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

Workflow [PR], commit [ff4c649]

@arthurpassos arthurpassos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear I thought I had already implemented this. It either got lost during ports or I abandoned this for a reason

Comment thread tests/queries/0_stateless/03572_export_merge_tree_part_special_columns.sh Outdated
Comment thread tests/queries/0_stateless/03572_export_merge_tree_part_basic.sh
Comment thread tests/queries/0_stateless/03604_export_merge_tree_partition.sh Outdated
…rtition_exports for partitions

Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
@CarlosFelipeOR

Copy link
Copy Markdown
Collaborator Author

@arthurpassos , I’ve addressed all your comments. Could you please review it again?

@arthurpassos arthurpassos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CICD is happy with it

# EXPORT PARTITION runs in the background, so wait for it instead of sleeping.
# $1 is how many partition exports should have completed by this point, counted from the
# start of the test (the table keeps one row per export operation).
function wait_for_partition_exports()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think it's better if you provide the partition id or transaction id you are waiting for instead of the count.

In any case, I suppose this is good enough for testing code

@CarlosFelipeOR CarlosFelipeOR added the verified Approved for release label Aug 25, 2026
@CarlosFelipeOR

Copy link
Copy Markdown
Collaborator Author

QA Verification — ✅

All four tests changed in this PR passed on every job.

The remaining failures are pre-existing and unrelated to this PR:

@zvonand
zvonand merged commit 94fe5ae into antalya-26.6 Aug 25, 2026
232 of 245 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants