Conversation
chadmed
requested changes
Sep 7, 2026
chadmed
approved these changes
Sep 7, 2026
Member
|
Please mention explicitly in the commit message that the mode with the best score isn't necessary a preferred mode and that using one of the preferred modes is a better match for some displays. Example with a few modes from your display would be nice. Implementation wise I wonder whether it would make sense to just add |
nohenry
force-pushed
the
preferred-dispay-mode
branch
2 times, most recently
from
September 16, 2026 22:23
a0eca00 to
2346dd8
Compare
The DCP display properties contains a preferred mode flag. This patch takes that into account when picking which mode to assign DRM_MODE_TYPE_PREFERRED Note: the mode with the highest DCP score isn't necessarily the best mode, the IsPreferred flag in DCP needs to be taken into account as well. We add (1 << 32) to the score when the preferred flag is set for simplicity. Signed-off-by: Oliver Clarke <oliverhenryc@gmail.com>
nohenry
force-pushed
the
preferred-dispay-mode
branch
from
September 16, 2026 22:23
2346dd8 to
7299d2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DCP display properties contains a preferred mode flag. This patch takes that into account when picking which mode to assign DRM_MODE_TYPE_PREFERRED