Expand configure.sh and consolidate CI - #1149
Merged
stonedDiscord merged 33 commits intoAug 24, 2026
Merged
Conversation
Contributor
Author
|
I guess we also get linux arm builds and mac builds |
Use the CamelCase variant everywhere, except macos+win dist, where we add a space. The Linux .desktop file gets a space too
Contributor
Author
finally looks decent on ubuntu
|
Contributor
Author
|
good to merge |
stonedDiscord
left a comment
stonedDiscord
left a comment
Member
There was a problem hiding this comment.
the code is ok, the part intended for humans to be read got worse.
| cd "${ROOT_DIR}" | ||
|
|
||
| if [ -f ./build.env ]; then | ||
| # shellcheck disable=SC1091 |
Contributor
Author
There was a problem hiding this comment.
all sh files are shellchecked for quality, this note says to disable one specific check for the next line
| QString get_app_path(); | ||
| QString get_base_path(); | ||
|
|
||
| // macOS only: on first run, seed the writable base (in Application Support) from |
Member
There was a problem hiding this comment.
this doesn't need the comment
stonedDiscord
approved these changes
Aug 24, 2026
OmniTroid
pushed a commit
to OmniTroid/AO2-Client
that referenced
this pull request
Aug 25, 2026
Fixes the path to be the proper path for gitignore. From AttorneyOnline#1149.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One script that does "just prepare for compiling pls" is cool and good