[AKS] az aks install-cli: Add optional native Azure skills installation - #34101
Open
Tom Gamble (gambtho) wants to merge 18 commits into
Open
Tom Gamble (gambtho) wants to merge 18 commits into
Tom Gamble (gambtho) wants to merge 18 commits into
Conversation
Tom Gamble (gambtho)
requested review from
a team and
FumingZhang
as code owners
September 19, 2026 02:06
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
elvazhu521,
Yu Chen (jsntcy),
ZelinWang (wangzelin007),
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 19, 2026 02:06
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The changes require final human review because they are too complex or risky for automated approval.
Review effort: Lite
Findings: None
What changed in this PR
Adds opt-in native Azure skills installation to az aks install-cli, preserving existing binary behavior while supporting agent detection, safe downloads, staging, and non-overwriting publication.
Changes:
- Adds interactive and explicit skills-installation modes with agent selection.
- Implements bounded GitHub release retrieval, archive validation, and secure publication.
- Adds extensive tests, help text, and design/implementation documentation.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py | Updated as part of this pull request. |
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_azure_skills.py | Updated as part of this pull request. |
| src/azure-cli/azure/cli/command_modules/acs/custom.py | Updated as part of this pull request. |
| src/azure-cli/azure/cli/command_modules/acs/_params.py | Updated as part of this pull request. |
| src/azure-cli/azure/cli/command_modules/acs/_help.py | Updated as part of this pull request. |
| src/azure-cli/azure/cli/command_modules/acs/_azure_skills.py | Updated as part of this pull request. |
| docs/superpowers/specs/2026-09-18-aks-azure-skills-design.md | Updated as part of this pull request. |
| docs/superpowers/plans/2026-09-18-aks-azure-skills.md | Updated as part of this pull request. |
| docs/superpowers/implementation/2026-09-19-aks-azure-skills.md | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ❌ Action needed
❌AzureCLI-FullTest
Related command
az aks install-cliDescription
Offer native, opt-in installation of Microsoft Azure skills after the existing kubectl and kubelogin installation succeeds.
--only-show-errors. Use native Knack prompts and typed Azure CLI errors.--install-azure-skills true|falseand--skills-agents. Explicit installation requires targets and bypasses prompts; omitted noninteractive execution and explicit false preserve binary-only behavior.microsoft/azure-skillsrelease by resolved commit, install complete skill trees/resources and license notices, and report provenance. Install no MCP configuration, hooks, or agent applications; add no runtime dependencies.--gh-tokenfor trusted GitHub metadata requests only. Bound transport/download/extraction, reject unsafe archive paths and destination indirection, and stage before publication.Codex uses the shared
~/.agents/skillsdirectory, so deselecting another agent does not prevent that agent from discovering shared skills. Selection controls installation destinations, not agent enablement.Testing Guide
After running the CLI from this branch:
Run unprivileged when testing skills installation. If default binary destinations need elevated access, use user-writable
--install-locationand--kubelogin-install-locationpaths, including the binary filenames. A skills acceptance installs into the selected user-level directories; automated verification instead used temporary destinations.Verification performed on Linux/Python 3.14 with worktree source overlays:
test_azure_skills,test_custom, andtest_validators: 402 tests run, 400 passed, 2 known skips.git diff --check: passed.v1.2.49(abaf74ac8f62fbe9f83d7ccb2bd991dca929a4da) smoke after the conformance changes: 28 installations, then 28 identical no-ops; all 926 original payload files byte-matched; notices retained; temporary state removed.The two skips are native Windows junction coverage and an existing kubelogin custom-source test. Existing ResourceWarnings/datetime deprecations remain unchanged. Native Windows/macOS, Python 3.10 runtime, full azdev ACS/style/linter gates, and actual agent/MCP workflows have not been exercised locally; CI/platform review remains necessary.
History Notes
[AKS]
az aks install-cli: Add optional native Azure skills installation for coding agents