Skip to content

[AutoPR azure-mgmt-containerserviceaimanager]-generated-from-SDK Generation - Python-6845674 - #49056

Open
azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-mgmt-containerserviceaimanager-6845674
Open

azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-mgmt-containerserviceaimanager-6845674

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Configurations: 'specification/containerservice/resource-manager/Microsoft.ContainerService/aimanager/tspconfig.yaml', API Version: 2026-09-02-preview, SDK Release Type: beta, and CommitSHA: '710828f4424a112000ac9a81896a8648f87b7548' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6845674 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36573 Submitted by: weisara@microsoft.com

…osoft.ContainerService/aimanager/tspconfig.yaml', API Version: 2026-09-02-preview, SDK Release Type: beta, and CommitSHA: '710828f4424a112000ac9a81896a8648f87b7548' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6845674 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copilot AI balanced review requested due to automatic review settings September 16, 2026 22:15
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Sep 16, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The broad generated public API expansion and documented breaking changes require final human API review.

Pull request overview

Updates the Container Service AI Manager beta SDK to API version 2026-09-02-preview.

Changes:

  • Adds custom AI model operations, Microsoft Foundry sources, managed identity credentials, and BYO AKS support.
  • Removes the calculate_cost request body.
  • Bumps the package to 1.0.0b2 and refreshes generated artifacts.
File summaries
File Description
tsp-location.yaml Updates the specification commit.
generated_tests/test_container_service_ai_manager_mgmt_model_sources_operations.py Updates synchronous model-source test scaffolding.
generated_tests/test_container_service_ai_manager_mgmt_model_sources_operations_async.py Updates asynchronous model-source test scaffolding.
generated_tests/test_container_service_ai_manager_mgmt_custom_ai_models_operations.py Adds synchronous custom-model test scaffolding.
generated_tests/test_container_service_ai_manager_mgmt_custom_ai_models_operations_async.py Adds asynchronous custom-model test scaffolding.
generated_tests/test_container_service_ai_manager_mgmt_ai_models_operations.py Removes the cost request body.
generated_tests/test_container_service_ai_manager_mgmt_ai_models_operations_async.py Removes the asynchronous cost request body.
generated_tests/test_container_service_ai_manager_mgmt_ai_managers_operations.py Adds the BYO cluster field.
generated_tests/test_container_service_ai_manager_mgmt_ai_managers_operations_async.py Adds the asynchronous BYO cluster field.
generated_samples/operations_list.py Updates the source API version.
generated_samples/model_sources_list.py Updates the source API version.
generated_samples/model_sources_get.py Updates the source API version.
generated_samples/model_sources_delete.py Updates the source API version.
generated_samples/model_sources_create_or_update.py Updates the source API version.
generated_samples/model_sources_create_or_update_managed_identity.py Adds a managed-identity Foundry source sample.
generated_samples/model_deployments_list_by_ai_manager_namespace.py Updates the source API version.
generated_samples/model_deployments_get.py Updates the source API version.
generated_samples/model_deployments_delete.py Updates the source API version.
generated_samples/model_deployments_create_or_update.py Updates the model resource identifier.
generated_samples/custom_ai_models_list.py Adds a custom-model listing sample.
generated_samples/custom_ai_models_get.py Adds a custom-model retrieval sample.
generated_samples/custom_ai_models_delete.py Adds a custom-model deletion sample.
generated_samples/custom_ai_models_create_or_update.py Adds a custom-model registration sample.
generated_samples/custom_ai_models_calculate_cost.py Adds a custom-model cost sample.
generated_samples/ai_models_list.py Updates the source API version.
generated_samples/ai_models_get.py Updates the source API version.
generated_samples/ai_models_calculate_cost.py Removes the cost request body.
generated_samples/ai_managers_update.py Updates the source API version.
generated_samples/ai_managers_list_credential.py Updates the source API version.
generated_samples/ai_managers_list_by_subscription.py Updates the source API version.
generated_samples/ai_managers_list_by_resource_group.py Updates the source API version.
generated_samples/ai_managers_get.py Updates the source API version.
generated_samples/ai_managers_get_byo.py Adds a BYO AI Manager retrieval sample.
generated_samples/ai_managers_delete.py Updates the source API version.
generated_samples/ai_managers_create_or_update.py Updates the source API version.
generated_samples/ai_managers_create_or_update_byo.py Adds a BYO AKS creation sample.
generated_samples/ai_manager_namespaces_rotate_keys.py Updates the source API version.
generated_samples/ai_manager_namespaces_list_credential.py Updates the source API version.
generated_samples/ai_manager_namespaces_list_by_ai_manager.py Updates the source API version.
generated_samples/ai_manager_namespaces_list_access_keys.py Updates the source API version.
generated_samples/ai_manager_namespaces_get.py Updates the source API version.
generated_samples/ai_manager_namespaces_delete.py Updates the source API version.
generated_samples/ai_manager_namespaces_create_or_update.py Updates the source API version.
CHANGELOG.md Documents version 1.0.0b2.
azure/mgmt/containerserviceaimanager/types.py Adds new typed request and model shapes.
azure/mgmt/containerserviceaimanager/operations/_patch.py Refreshes generated patch formatting.
azure/mgmt/containerserviceaimanager/operations/__init__.py Exports custom-model operations.
azure/mgmt/containerserviceaimanager/models/_patch.py Refreshes generated patch formatting.
azure/mgmt/containerserviceaimanager/models/_models.py Adds generated model implementations.
azure/mgmt/containerserviceaimanager/models/_enums.py Adds custom-model and Foundry enum values.
azure/mgmt/containerserviceaimanager/models/__init__.py Exports the new models and enum.
azure/mgmt/containerserviceaimanager/aio/operations/_patch.py Refreshes asynchronous patch formatting.
azure/mgmt/containerserviceaimanager/aio/operations/_operations.py Adds asynchronous custom-model operations.
azure/mgmt/containerserviceaimanager/aio/operations/__init__.py Exports asynchronous custom-model operations.
azure/mgmt/containerserviceaimanager/aio/_patch.py Refreshes asynchronous patch formatting.
azure/mgmt/containerserviceaimanager/aio/_configuration.py Updates the asynchronous API version.
azure/mgmt/containerserviceaimanager/aio/_client.py Exposes asynchronous custom-model operations.
azure/mgmt/containerserviceaimanager/_version.py Bumps the package to 1.0.0b2.
azure/mgmt/containerserviceaimanager/_validation.py Removes obsolete API-version validation.
azure/mgmt/containerserviceaimanager/_patch.py Refreshes generated patch formatting.
azure/mgmt/containerserviceaimanager/_configuration.py Updates the synchronous API version.
azure/mgmt/containerserviceaimanager/_client.py Exposes synchronous custom-model operations.
apiview-properties.json Maps the expanded API surface.
api.metadata.yml Updates API metadata and package version.
api.md Regenerates the documented public API.
_metadata.json Records the new specification and emitter versions.
Review details
  • Files reviewed: 67/67 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Management SDK PR review

Findings: None.

Unverified checks

Unverified checks: None.

Breaking-change attribution

Package: sdk/containerservice/azure-mgmt-containerserviceaimanager | Release: 1.0.0b2 (2026-09-16)

Changelog entry Cause Evidence and explanation Confidence
Deleted or renamed model CalculateCostRequest TypeSpec/API At the merge-base spec commit, AIModels.calculateCost used CalculateCostRequest as its request body (merge base, L190-L193). At the latest spec commit, the action's body parameter was changed to void (latest, L180-L183). The CalculateCostRequest model definition itself is still present in the latest .tsp file (latest, L62) but is no longer referenced by any operation, so the Python generator no longer emits it as a public model — directly explaining the changelog entry. High — direct before/after TypeSpec diff shows the parameter/model reference removal that the generator would prune.
Method AIModelsOperations.calculate_cost deleted or renamed its parameter body of kind positional_or_keyword TypeSpec/API Same action-signature change as above: the calculateCost operation's request body parameter changed from CalculateCostRequest (merge base, L190-L193) to void (latest, L180-L183), which directly removes the generated body parameter from the SDK method. High — direct evidence of the API-version-scoped signature change.
AIModelsOperations.calculate_cost had all overloads removed TypeSpec/API The generator emits separate JSON/IO overloads only when an operation accepts a request body model; since the body parameter was changed to void in the same action definition (latest, L180-L183) versus CalculateCostRequest at the merge base (merge base, L190-L193), the body-model overloads are no longer generated. High — same signature change as the two entries above; consistent, single root cause.

Review summary

Reviewed sdk/containerservice/azure-mgmt-containerserviceaimanager (the only affected package). Checked: version/CHANGELOG consistency, preview API version vs. beta SDK version, CHANGELOG release-date reasonableness, pyproject.toml stability flags, client __init__ signature/parameter order, client name consistency across _client.py/README/pyproject.toml, and README code-snippet accuracy — no violations found. API version is unchanged (2026-09-02-preview at both first and latest revisions). All three introduced Breaking Changes entries were traced to a single TypeSpec change (the calculateCost action's request body parameter changed from CalculateCostRequest to void) with high-confidence evidence at both the merge-base and latest specification commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants