Skip to content

[AutoPR azure-mgmt-trafficmanager]-generated-from-SDK Generation - Python-6845866 - #49060

Open
azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-mgmt-trafficmanager-6845866
Open

azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sdkauto/azure-mgmt-trafficmanager-6845866

Conversation

@azure-sdk-automation

@azure-sdk-automation azure-sdk-automation Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Configurations: 'specification/trafficmanager/resource-manager/Microsoft.Network/TrafficManager/tspconfig.yaml', API Version: 2026-09-01, SDK Release Type: stable, and CommitSHA: 'dd536c5bba9374d7820ca5043ee2b11e15bedc58' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6845866 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36282 Submitted by: ranjanasinha@microsoft.com

Release Plan Details

…oft.Network/TrafficManager/tspconfig.yaml', API Version: 2026-09-01, SDK Release Type: stable, and CommitSHA: 'dd536c5bba9374d7820ca5043ee2b11e15bedc58' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6845866 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Copilot AI balanced review requested due to automatic review settings September 16, 2026 22:48
@azure-sdk-automation azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Sep 16, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No blocking issues were identified; only minor documentation and metadata nits remain.

Pull request overview

Regenerates the Traffic Manager Python SDK for stable API version 2026-09-01 and package version 2.0.0.

Changes:

  • Regenerates clients, operations, models, types, serialization, and samples.
  • Updates package metadata, documentation, changelog, and APIView artifacts.
  • Refreshes API-version and release metadata.
File summaries
File Summary
sdk/trafficmanager/azure-mgmt-trafficmanager/tsp-location.yaml Updates the specification commit.
sdk/trafficmanager/azure-mgmt-trafficmanager/README.md Refreshes authentication terminology.
sdk/trafficmanager/azure-mgmt-trafficmanager/pyproject.toml Updates stable metadata and Python requirements; “Trafficmanager” spelling nit remains.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/traffic_manager_user_metrics_keys_put.py Regenerated user metrics keys PUT sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/traffic_manager_user_metrics_keys_get.py Regenerated user metrics keys GET sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/traffic_manager_user_metrics_keys_delete.py Regenerated user metrics keys DELETE sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_put_with_nested_endpoints.py Regenerated nested-endpoints profile PUT sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_put_with_endpoints.py Regenerated profile PUT sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_put_with_endpoints_and_record_type.py Regenerated profile PUT sample with record type.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_put_with_custom_headers.py Regenerated custom-header profile PUT sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_put_with_aliasing.py Regenerated aliased profile PUT sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_put_no_endpoints.py Regenerated profile PUT sample without endpoints.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_put_multi_value.py Regenerated multi-value profile PUT sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_patch_record_type.py Regenerated profile PATCH sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_patch_monitor_config.py Regenerated monitor-configuration PATCH sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_get_without_record_type.py Regenerated profile GET sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_get_with_traffic_view_enabled.py Regenerated traffic-view-enabled profile GET sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_get_with_traffic_view_disabled.py Regenerated traffic-view-disabled profile GET sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_get_with_endpoints.py Regenerated profile GET sample with endpoints.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_get_with_endpoints_and_record_type.py Regenerated profile GET sample with endpoints and record type.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_get_by_subscription.py Regenerated subscription-level profile GET sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_get_by_resource_group.py Regenerated resource-group profile GET sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/profile_delete.py Regenerated profile DELETE sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/name_availability_v2_test_name_not_available_postexample23.py Regenerated v2 unavailable-name sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/name_availability_v2_test_name_available_postexample21.py Regenerated v2 available-name sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/name_availability_test_name_not_available_postexample23.py Regenerated unavailable-name sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/name_availability_test_name_available_postexample21.py Regenerated available-name sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/heat_map_get.py Regenerated heat map GET sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/heat_map_get_with_top_left_bot_right.py Regenerated bounded heat map GET sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/heat_map_get_with_null_values.py Regenerated null-value heat map GET sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/geographic_hierarchy_getdefault.py Regenerated geographic hierarchy sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/endpoint_put_external_with_subnet_mapping.py Regenerated external endpoint PUT sample with subnet mapping.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/endpoint_put_external_with_location.py Regenerated external endpoint PUT sample with location.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/endpoint_put_external_with_geo_mapping.py Regenerated external endpoint PUT sample with geographic mapping.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/endpoint_put_external_with_custom_headers.py Regenerated custom-header external endpoint PUT sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/endpoint_put_external_with_always_serve.py Regenerated always-serve external endpoint PUT sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/endpoint_patch_external_target.py Regenerated external target PATCH sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/endpoint_get_external_with_subnet_mapping.py Regenerated external endpoint GET sample with subnet mapping.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/endpoint_get_external_with_location.py Regenerated external endpoint GET sample with location.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/endpoint_get_external_with_geo_mapping.py Regenerated external endpoint GET sample with geographic mapping.
sdk/trafficmanager/azure-mgmt-trafficmanager/generated_samples/endpoint_delete_external.py Regenerated external endpoint DELETE sample.
sdk/trafficmanager/azure-mgmt-trafficmanager/CHANGELOG.md Documents the stable release.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/types.py Adds generated request types; minor generated docstring wording nits remain.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/operations/_operations.py Updates synchronous operations and API defaults.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/models/_models.py Regenerates management models.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/aio/operations/_operations.py Updates asynchronous operations.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/aio/_configuration.py Updates asynchronous API-version configuration.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/aio/_client.py Regenerates the asynchronous client; API-version docstring nit remains.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/_version.py Updates the package version to 2.0.0.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/_utils/serialization.py Updates serialization helpers.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/_utils/model_base.py Updates model serialization support.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/_configuration.py Updates API-version configuration defaults.
sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/_client.py Regenerates the synchronous client; API-version docstring nit remains.
sdk/trafficmanager/azure-mgmt-trafficmanager/apiview-properties.json Updates APIView metadata.
sdk/trafficmanager/azure-mgmt-trafficmanager/api.metadata.yml Updates API documentation metadata.
sdk/trafficmanager/azure-mgmt-trafficmanager/api.md Updates the generated API surface.
sdk/trafficmanager/azure-mgmt-trafficmanager/_metadata.json Records API, commit, and generator metadata.
Review details

Suppressed comments (6)

sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/_client.py:66

  • This public client docstring says the API version defaults to None, but the constructor passes api_version to the configuration, whose default is "2026-09-01". That makes the documented default inconsistent with the request behavior; please document the actual default (and regenerate the async client consistently).
    :keyword api_version: The API version to use for this operation. Known values are "2026-09-01"
     and None. Default value is None. If not set, the operation's default API version will be used.
     Note that overriding this default value may result in unsupported behavior.

sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/aio/_client.py:66

  • This async client docstring says the API version defaults to None, but the constructor passes api_version to the configuration, whose default is "2026-09-01". That makes the documented default inconsistent with the request behavior; please document the actual default.
    :keyword api_version: The API version to use for this operation. Known values are "2026-09-01"
     and None. Default value is None. If not set, the operation's default API version will be used.
     Note that overriding this default value may result in unsupported behavior.

sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/types.py:128

  • This generated docstring says of the of the endpoint, which is grammatically incorrect and will surface in the published API documentation. Please correct the source description so regeneration does not reintroduce the typo.
    :ivar targetResourceId: The Azure Resource URI of the of the endpoint. Not applicable to
     endpoints of type 'ExternalEndpoints'.

sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/types.py:281

  • The generated docstring uses response as a verb (endpoints ... to response); it should be respond. Please correct the source description so the published API documentation is grammatical.
    :ivar timeoutInSeconds: The monitor timeout for endpoints in this profile. This is the time
     that Traffic Manager allows endpoints in this profile to response to the health check.
    :vartype timeoutInSeconds: int

sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/types.py:408

  • The generated documentation calls this a Traffic Manage profile, omitting the final r from the product name. Please correct the source description so the published API documentation consistently says Traffic Manager.
    :ivar trafficViewEnrollmentStatus: Indicates whether Traffic View is 'Enabled' or 'Disabled'
     for the Traffic Manager profile. Null, indicates 'Disabled'. Enabling this feature will
     increase the cost of the Traffic Manage profile. Known values are: "Enabled" and "Disabled".

sdk/trafficmanager/azure-mgmt-trafficmanager/azure/mgmt/trafficmanager/types.py:435

  • The corresponding property docstring repeats the product typo as Traffic Manage profile. Please correct this generated description as well as the field description above so both published forms say Traffic Manager.
    """Indicates whether Traffic View is 'Enabled' or 'Disabled' for the Traffic Manager profile.
     Null, indicates 'Disabled'. Enabling this feature will increase the cost of the Traffic Manage
     profile. Known values are: \"Enabled\" and \"Disabled\"."""
  • Files reviewed: 57/57 changed files
  • Comments generated: 1
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread sdk/trafficmanager/azure-mgmt-trafficmanager/pyproject.toml
@ChenxiJiang333 ChenxiJiang333 added the mgmt-review-needed PR for Mgmt SDK is ready to review label Sep 18, 2026
@ChenxiJiang333 ChenxiJiang333 added mgmt-review-needed PR for Mgmt SDK is ready to review and removed mgmt-review-needed PR for Mgmt SDK is ready to review labels Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Management SDK PR review

Findings: None.

Unverified checks

None.

Breaking-change attribution

Package: sdk/trafficmanager/azure-mgmt-trafficmanager | Release: 2.0.0 (2026-09-16)

Changelog entry Cause Evidence and explanation Confidence
Model Endpoint deleted or renamed its instance variable always_serve (and 12 other Endpoint instance-variable removals: custom_headers, endpoint_location, endpoint_monitor_status, endpoint_status, geo_mapping, min_child_endpoints, min_child_endpoints_i_pv4, min_child_endpoints_i_pv6, priority, subnets, target, target_resource_id, weight) Human review Needs human review. Compared Endpoint.tsp and models.tsp EndpointProperties at the release-baseline revision 28e08376806422730d28d8dd90479d0ad68397ac against the same files at the latest revision dd536c5bba9374d7820ca5043ee2b11e15bedc58; both the Endpoint resource shape (properties?: EndpointProperties) and the EndpointProperties field list are unchanged apart from an @added(Versions.v2026_09_01) annotation on an unrelated field and a doc-comment wording update. No TypeSpec model change explains flattening these properties.* fields onto the top-level Endpoint SDK model; this looks like a generator/model-flattening behavior change rather than a spec change. N/A
Model HeatMapModel deleted or renamed its instance variable end_time (and 3 others: endpoints, start_time, traffic_flows) Human review Needs human review. Compared HeatMapModel.tsp at both revisions; the only difference is @@doc`` formatting (line wrapping), no field or type change. No TypeSpec evidence explains this SDK-level flattening. N/A
Model Profile deleted or renamed its instance variable allowed_endpoint_record_types (and 6 others: dns_config, endpoints, max_return, monitor_config, profile_status, traffic_routing_method, traffic_view_enrollment_status) Human review Needs human review. Profile.tsp/models.tsp ProfileProperties were not found to differ between the two revisions in the areas inspected; no direct TypeSpec evidence connects this to a spec change within the investigation budget. N/A
Model TrafficManagerGeographicHierarchy deleted or renamed its instance variable geographic_hierarchy Human review Needs human review. No TypeSpec model change identified for this model between the two pinned revisions. N/A
Model UserMetricsModel deleted or renamed its instance variable key Human review Needs human review. No TypeSpec model change identified for this model between the two pinned revisions. N/A
Deleted or renamed model ProfileListResult Human review Needs human review. models.tsp still defines ProfileListResult at the latest revision; no TypeSpec removal evidence found. Likely a generator-side type change (e.g., paged-list handling) rather than a spec change. N/A
Method HeatMapOperations.get changed type of its parameter bot_right from List[float] to list[float] Human review Needs human review. HeatMapModel.tsp defines botRight?: float64[] unchanged at both revisions. The List[float]list[float] notation change looks like a generator/Python-version typing convention change, not a spec change. N/A
Method HeatMapOperations.get changed its parameter bot_right from positional_or_keyword to keyword_only Human review Needs human review. botRight is declared @query(\"botRight\") botRight?: float64[] unchanged in both TypeSpec revisions; no versioning annotation or parameter-kind change found in the spec. N/A
Method HeatMapOperations.get changed type of its parameter heat_map_type from str to Union[str, HeatMapType] Human review Needs human review. HeatMapType enum in models.tsp is unchanged between revisions; no spec change found that would explain a typing change for this parameter. N/A
Method HeatMapOperations.get removed default value None from its parameter heat_map_type Human review Needs human review. No TypeSpec change identified affecting heatMapType's optionality/default in HeatMapModel.tsp. N/A
Method HeatMapOperations.get changed its parameter heat_map_type from keyword_only to positional_or_keyword Human review Needs human review. No TypeSpec change identified for heatMapType's parameter kind. N/A
Method HeatMapOperations.get changed type of its parameter top_left from List[float] to list[float] Human review Needs human review. topLeft?: float64[] unchanged between revisions in HeatMapModel.tsp; typing-notation change appears generator-driven. N/A
Method HeatMapOperations.get changed its parameter top_left from positional_or_keyword to keyword_only Human review Needs human review. No TypeSpec change identified for topLeft's parameter kind. N/A

Review summary

Reviewed package sdk/trafficmanager/azure-mgmt-trafficmanager (only affected package). API-version drift check: unchanged (both first and latest PR revisions resolve to API version 2026-09-01; no finding). Verified version consistency (_version.py 2.0.0 matches CHANGELOG.md ## 2.0.0 (2026-09-16)), pyproject.toml stability flags (is_stable = true, "Development Status :: 5 - Production/Stable" present, consistent with non-beta version), client __init__ signature order (credential, subscription_id, base_url), client name consistency (TrafficManagerManagementClient in _client.py, README.md, and pyproject.toml title), README code snippet correctness, and changelog date (2026-09-16, not more than 3 weeks in the future). All 34 newly introduced Breaking Changes entries were compared against the TypeSpec sources at the release-baseline (28e08376806422730d28d8dd90479d0ad68397ac) and latest (dd536c5bba9374d7820ca5043ee2b11e15bedc58) revisions; no direct TypeSpec/API evidence was found connecting them to spec changes within the investigation budget, so all are flagged for human review as likely generator/model-flattening or typing-convention changes rather than spec-driven changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. mgmt-review-needed PR for Mgmt SDK is ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants