Fix Service Fabric HTTPAdapter subclass compatibility - #964
Merged
Nilesh Choudhary (4gust) merged 1 commit intoSep 17, 2026
Merged
Conversation
Accept HTTPAdapter subclasses as configuration sources while retaining MSAL's isolated certificate-pinned transport. Add regression coverage for pin validation, supported adapter types, and caller transport isolation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Nilesh Choudhary (4gust)
September 17, 2026 09:45
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Fixes Service Fabric managed identity compatibility with HTTPAdapter subclasses while preserving isolated certificate-pinned transport behavior.
Changes:
- Accepts adapter subclasses and copies retry/pool settings.
- Preserves transport isolation and adapter validation.
- Expands TLS, configuration, and subclass test coverage.
File summaries
| File | Summary |
|---|---|
tests/test_mi.py |
Adds subclass, isolation, and validation coverage. |
msal/managed_identity.py |
Supports adapter subclasses with pinned transport isolation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Gladwin Johnson VR (gladjohn)
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept
HTTPAdaptersubclasses for Service Fabric while preserving certificate pinning.Adds regression tests for subclass support, certificate rejection, and transport isolation. All 60 managed-identity tests pass.
This PR covers adapter compatibility only; the Azure Identity wrapper integration is separate.
Related to #963.