VAPI-3804: Add onDtmfSent callback for locally-sent DTMF tone events - #16
Merged
Conversation
Consumers previously had no way to know when a queued DTMF tone actually played on a published stream. Wire the browser's native RTCDTMFSender "tonechange" event through onDtmfSent, mirroring the existing onReady/onStreamAvailable callback pattern. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
stampercasey
approved these changes
Aug 20, 2026
This was referenced Aug 20, 2026
Open
smoghe-bw
added a commit
to Bandwidth/kotlin-brtc-sdk
that referenced
this pull request
Aug 27, 2026
) Ports the JS SDK's onDtmfSent feature (Bandwidth/javascript-brtc-sdk#16, already ported to Swift in Bandwidth/swift-brtc-sdk#21) to the Kotlin/Android SDK. Fires once per valid DTMF character passed to sendDtmf, once insertDtmf succeeds on the publishing peer connection's audio sender. Co-authored-by: smoghe-bw <smoghe-bw> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
smoghe-bw
added a commit
to Bandwidth/swift-brtc-sdk
that referenced
this pull request
Aug 27, 2026
) Ports the JS SDK's onDtmfSent feature (Bandwidth/javascript-brtc-sdk#16). iOS WebRTC's RTCDtmfSender has no tonechange-equivalent delegate, so the callback fires once per tone immediately after insertDtmf is queued rather than after actual playback confirmation. Co-authored-by: smoghe-bw <smoghe-bw> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DtmfSentEvent/DtmfSentHandlertypes and anonDtmfSent(callback)registration method, following the existingonReady/onStreamAvailablepattern.RTCDTMFSendertonechangeevent so consumers are notified once per tone actually played on a published stream (the empty-tone "queue drained" event is filtered out).Test plan
tsc --noEmitpassesjest srcpasses (had to guard the newtonechangelistener withaddEventListener?.()since existingRTCDTMFSendertest mocks don't implementEventTarget)prettier --checkpassesJira: https://bandwidth-jira.atlassian.net/browse/VAPI-3804
🤖 Generated with Claude Code