Skip to content

Vis fixes3 - #292

Closed
stephanmg wants to merge 7 commits into
Benchmarking-Initiative:masterfrom
stephanmg:vis_fixes3
Closed

Vis fixes3#292
stephanmg wants to merge 7 commits into
Benchmarking-Initiative:masterfrom
stephanmg:vis_fixes3

Conversation

@stephanmg

@stephanmg stephanmg commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator

Empty fields (e.g. for plotName) lead to 'nan' value for title of plot.

Therefore changed empty fields to a field entry with the space character.

@stephanmg

Copy link
Copy Markdown
Collaborator Author

Potentially only relevant for rather old petab versions, tested version with this issue is <=0.5.0.

@stephanmg
stephanmg marked this pull request as draft November 21, 2025 17:40

@plakrisenko plakrisenko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files are changed

@stephanmg
stephanmg marked this pull request as ready for review November 24, 2025 14:41
@dilpath

dilpath commented Nov 26, 2025

Copy link
Copy Markdown
Collaborator

Should this be fixed in the plotting code instead?

@stephanmg

Copy link
Copy Markdown
Collaborator Author

Should this be fixed in the plotting code instead?

I think the issue is only reproducible in older petab versions - so, we could also discard my changes and argue not to use older petab versions).

@dilpath dilpath closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants