Update Assert, fix NAG errors - #207
Merged
Merged
Conversation
`-DASSERT_MULTI_IMAGE -DASSERT_PARALLEL_CALLBACKS` are necessary to avoid linker conflicts caused by different Assert build configurations in libjulienne vs libcaffeine. Add a note clarifying that fpm `--link-flag` alone is insufficient on Linux.
-fpp/-cpp options should no longer be required for Intel and NAG
NAG rejects empty source files, and empty modules/submodules. Deploy a macro to uniformly handle "stubbing out" module files. NAG 7.2.7251 x64/Linux crashes at compile and/or runtime with -O2 or higher on the file_t test.
Module save procedure pointers initially have undefined association status, and we were incorrectly relying on equivalence to unassociated. This was causing crashes on NAG.
…ort.F90 This header file is injected into the include path of clients by fpm, so file names need to use a unique prefix. In particular, this was already causing a file name collision with Caffeine (which also has a `language-support.F90` header), which only went unnoticed until now because the contents were sufficiently similar.
Ensure FPM build artifacts land in an isolated directory
bonachea
force-pushed
the
assert-update
branch
from
September 14, 2026 23:24
6c8a0ab to
9d02fc0
Compare
bonachea
force-pushed
the
assert-update
branch
from
September 15, 2026 19:01
9d02fc0 to
74dab53
Compare
bonachea
marked this pull request as ready for review
September 15, 2026 19:03
bonachea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the Julienne companion to BerkeleyLab/assert#97
Clean up a random collection of problems discovered through manual testing:
JULIENNE_PARALLEL_CALLBACKSsupport, which was manifesting as runtime crashes with the NAG compiler.include/language-support.F90that could lead to compile errors.F90suffix for uniformity and maintainability. This also allows us to remove explicit preprocessing options from some compilers.