Skip to content

Ap 840:Metadata link doesn't allow download - #114

Open
yzhoubk wants to merge 4 commits into
mainfrom
AP-840
Open

Ap 840:Metadata link doesn't allow download#114
yzhoubk wants to merge 4 commits into
mainfrom
AP-840

Conversation

@yzhoubk

@yzhoubk yzhoubk commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

The download button which opens metadata in a new browser window, in the GeoBlacklight metadata modal is not working.
Update the related script from Geoblacklight to restore the download functionality, support multiple metadata standards in separate tabs, and ensure each button opens the corresponding metadata in a new window.

@yzhoubk
yzhoubk requested a review from anarchivist August 21, 2026 20:40

@anarchivist anarchivist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have some questions about the javascript. i can't get the download function (nor the metadata display in the modal) to work with ISO 19139 metadata.

Comment thread config/importmap.rb
pin '@github/auto-complete-element', to: 'https://cdn.skypack.dev/@github/auto-complete-element'
pin '@popperjs/core', to: 'https://ga.jspm.io/npm:@popperjs/core@2.11.6/dist/esm/popper.js'
pin 'bootstrap', to: 'https://ga.jspm.io/npm:bootstrap@5.3.2/dist/js/bootstrap.esm.js'
pin 'geoblacklight/initializers/metadata_download', to: 'geoblacklight/initializers/metadata_download.js'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this adequate to pull in all the dependencies needed by geoblacklight?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anarchivist

The metadata link is not displayed when a record does not include ISO 19139 metadata.

The default Solr sample records from GeoBlacklight are outdated. Most records either lack metadata or contain incorrectly formatted ISO metadata. As a result, the metadata link may not appear, or the metadata modal may display incorrect ISO information.

I ingested a record with valid ISO 19139 metadata from GeoCombine, which allows me to properly test the metadata modal and its buttons locally.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you give me an example record? i'm going based on the fixture data that is used for testing.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intended to be different from the initializer javascript shipped with GeoBlacklight 5.3.0? why do we need to override it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants