mnemonic: support all standard BIP39 word counts - #314
Open
ethicnology wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend Jade's mnemonic support from 12 and 24 words to all standard BIP39 lengths: 12, 15, 18, 21, and 24 words.
This centralizes word-count and entropy-length validation and applies it to mnemonic generation and restoration, passphrase-protected persistence, recovery phrase UI, final-word calculation, SeedQR and CompactSeedQR handling, and
ur:crypto-bip39imports. BIP85 remains limited to 12 and 24 words.Adds fixed BIP39 vectors and round-trip coverage for derivation, storage, text, SeedQR, and CompactSeedQR imports, including rejection of non-standard 27 and 30-word libwally extensions.