Add per-connection Electrum subscription limit - #251
Merged
philippem merged 2 commits intoAug 24, 2026
Conversation
A client can subscribe to unlimited scripthashes on a single Electrum connection, and each tracked subscription costs a history lookup on every new block. Add --electrum-subscription-limit (default 10000, 0 = unlimited) and reject new scripthash_subscribe calls past the cap while still allowing a client to refresh a subscription it already holds.
philippem
requested review from
DeviaVir,
EddieHouston,
FedOken,
Randy808 and
shesek
and removed request for
EddieHouston
August 24, 2026 15:23
DeviaVir
previously approved these changes
Aug 24, 2026
Collaborator
|
Added simple unit test in 514fe7c verifying that rejected subscriptions map to error code 1; existing tests cover the subscription_allowed() limit behavior. |
Randy808
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client can subscribe to unlimited scripthashes on a single Electrum connection, and each tracked subscription costs a history lookup on every new block. Add --electrum-subscription-limit (default 10000, 0 = unlimited) and reject new scripthash_subscribe calls past the cap while still allowing a client to refresh a subscription it already holds.