use read options in streaming API - #63
Merged
Merged
Conversation
Bloomca
commented
Aug 25, 2026
Bloomca
left a comment
Bloomca
left a comment
Owner
Author
There was a problem hiding this comment.
Posted by Llŷr
This PR folds TrackStreamOptions into the shared ReadOptions struct and moves chunk sizing onto TrackStream as a builder method. Streaming now re-applies the read-speed request on every chunk, so I strongly recommend addressing the feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use read options in streaming API. This required chunk size to be moved to the TrackStream struct, but since streaming is a 2 step process (open track for streaming and then get next chunk, seek, etc), it is not awkward API. That being said, the chunk size will probably be customizable in the future.
This is a breaking change, this is fine since the next version is 1.0