Skip to content

liveDelay not calculated yet icon - #175

Open
jchristman75 wants to merge 4 commits into
bp-devfrom
bp-livedelay-icon
Open

liveDelay not calculated yet icon#175
jchristman75 wants to merge 4 commits into
bp-devfrom
bp-livedelay-icon

Conversation

@jchristman75

Copy link
Copy Markdown
Collaborator

What

Adds an onroad steering-lag calibration indicator to both the TICI and MICI HUDs. While liveDelay.status is not yet estimated, a small icon appears near the wheel button (TICI) / top-right corner (MICI). It renders white when the car is too slow for lagd to collect samples and green once vEgo >= MIN_VEGO (15 m/s), so the driver can tell at a glance whether estimation is actually running. The icon disappears entirely once the estimate lands.

Why

Steering-lag calibration is invisible today — there is no way to know whether it is progressing, stalled, or already done, which makes "my steering feels off after a reset" reports hard to diagnose. Ported the concept from the sp-dev-c3 tree, minus its two progress bars: the bars added clutter without changing what the driver would do, and the green/white state already answers the only actionable question ("is it collecting right now?").

Also this calculation is changing soon, so this indication might be more valuable.

How

  • LiveDelayIndicator is a small shared widget in selfdrive/ui/bp/lib/, drawn by both HUD renderers so the TICI and MICI paths cannot drift apart. It reads liveDelay and carState straight off ui_state.sm — no new subscriptions, liveDelay is already in the SP sub list.
  • Sizing is a single width argument (140 TICI, 44 MICI); height derives from the icon's aspect ratio.
  • liveDelay.png is committed as a plain git blob, not LFS, with an exclusion line in .gitattributes matching the existing spinner_bluepilot.png precedent. The fork's pre-push hook deliberately skips LFS uploads (BluePilot consumes upstream LFS only), so an LFS-tracked asset added here resolves to a pointer that 404s on-device during smudge.

Changes

  • selfdrive/ui/bp/lib/live_delay_indicator.py: New LiveDelayIndicator widget — icon plus backdrop, hidden once liveDelay.status == 'estimated', green above MIN_VEGO.
  • selfdrive/ui/bp/onroad/hud_renderer_bp.py: Renders the indicator left of the wheel button, vertically centered on it.
  • selfdrive/ui/bp/mici/onroad/hud_renderer_bp.py: Renders the indicator in the top-right corner.
  • .gitattributes: Excludes liveDelay.png from the LFS filter.
  • selfdrive/assets/icons/liveDelay.png: New 387x270 icon asset.
  • ** also updated bluepilot branding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant