disallow an empty language ext without ext-seg - #1247
Merged
1 commit merged intoSep 17, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
change ABNF to disallow things like `ssvc/`, update the python pattern and the test cases accordingly. use a simplified ABNF rule for readablity, because `[ 1*elem ]` equals `*elem` and whitespace after braces is not necessary (and not always used in the file). resolve CERTCC#1233
bernhardreiter
requested review from
ahouseholder and
sei-vsarvepalli
as code owners
September 16, 2026 14:21
sei-vsarvepalli
approved these changes
Sep 16, 2026
Contributor
|
Hello @bernhardreiter Can you also update the It will also secure the checkout against supply-chain attacks. diff --git a/.github/workflows/run_doctools.yml b/.github/workflows/run_doctools.yml
index d5c098f1..b3139fc1 100644
--- a/.github/workflows/run_doctools.yml
+++ b/.github/workflows/run_doctools.yml
@@ -16,9 +16,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v7
+ - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
- ref: ${{ github.head_ref }}
+ repository: ${{ github.event.pull_request.head.repo.full_name }}
+ ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0 |
Contributor
|
I have the fix pushed din #1249 - including your regex/ABNF update. |
sei-vsarvepalli
closed this pull request by merging all changes
into
CERTCC:main
in
fa6a3a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change ABNF to disallow things like
ssvc/, update the python patternand the test cases accordingly.
use a simplified ABNF rule for readablity,
because
[ 1*elem ]equals*elemand whitespace after braces is notnecessary (and not always used in the file).
resolve #1233