Skip to content

Fix namespace abnf - #1251

Open
sei-vsarvepalli wants to merge 3 commits into
CERTCC:mainfrom
sei-vsarvepalli:fix-namespace-abnf
Open

sei-vsarvepalli wants to merge 3 commits into
CERTCC:mainfrom
sei-vsarvepalli:fix-namespace-abnf

Conversation

@sei-vsarvepalli

Copy link
Copy Markdown
Contributor

remove typo in the expansion of privateuse from RFC5646.

add the result of the Makefile run

resolve #1239

@sei-vsarvepalli
sei-vsarvepalli marked this pull request as ready for review September 17, 2026 21:27
Copilot AI lite review requested due to automatic review settings September 17, 2026 21:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Add regression coverage for one-character private-use subtags.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Fixes RFC 5646 private-use namespace matching and regenerates dependent artifacts.

Changes:

  • Corrects private-use subtag length to 1–8 characters.
  • Regenerates runtime patterns and v2 schemas.
  • Refreshes the object registry output.
File summaries
File Summary
src/ssvc/utils/ssvc_namespace_pattern.abnf Corrected private-use ABNF.
src/ssvc/utils/namespace_patterns.py Regenerated namespace patterns.
data/schema/v2/SsvcObjectRegistry_2_0_0.schema.json Regenerated namespace validation schema.
data/schema/v2/SelectionList_2_0_0.schema.json Regenerated namespace validation schema.
data/schema/v2/DecisionTable_2_0_0.schema.json Regenerated namespace validation schema.
data/schema/v2/DecisionPointGroup_2_0_0.schema.json Regenerated namespace validation schema.
data/schema/v2/DecisionPoint_2_0_0.schema.json Regenerated namespace validation schema.
data/json/ssvc_object_registry.json Refreshed generated registry output.
Review details

Suppressed comments (1)

src/ssvc/utils/namespace_patterns.py:42

  • The new lower bound is not covered by the namespace-pattern tests, so the RFC typo could regress without detection. Add a regression case such as ssvc/x-a to the valid namespace inputs (and keep the generated schema behavior covered through the same pattern).
    f'({alnum}){{2,8}})+)*(-[xX](-({alnum}){{1,8}})+)?|[xX](-'
    f'({alnum}){{1,8}})+|i-default|i-mingo)'
  • Files reviewed: 8/8 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/ssvc/utils/ssvc_namespace_pattern.abnf
@sei-vsarvepalli

Copy link
Copy Markdown
Contributor Author

can @bernhardreiter - take a look at this PR?

@bernhardreiter

Copy link
Copy Markdown
Contributor

@sei-vsarvepalli I will take a look (probably later this week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CSAF] Pattern wrong

3 participants