Fix namespace abnf - #1251
Open
sei-vsarvepalli wants to merge 3 commits into
Open
Fix namespace abnf#1251sei-vsarvepalli wants to merge 3 commits into
sei-vsarvepalli wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Add regression coverage for one-character private-use subtags.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes RFC 5646 private-use namespace matching and regenerates dependent artifacts.
Changes:
- Corrects private-use subtag length to 1–8 characters.
- Regenerates runtime patterns and v2 schemas.
- Refreshes the object registry output.
File summaries
| File | Summary |
|---|---|
src/ssvc/utils/ssvc_namespace_pattern.abnf |
Corrected private-use ABNF. |
src/ssvc/utils/namespace_patterns.py |
Regenerated namespace patterns. |
data/schema/v2/SsvcObjectRegistry_2_0_0.schema.json |
Regenerated namespace validation schema. |
data/schema/v2/SelectionList_2_0_0.schema.json |
Regenerated namespace validation schema. |
data/schema/v2/DecisionTable_2_0_0.schema.json |
Regenerated namespace validation schema. |
data/schema/v2/DecisionPointGroup_2_0_0.schema.json |
Regenerated namespace validation schema. |
data/schema/v2/DecisionPoint_2_0_0.schema.json |
Regenerated namespace validation schema. |
data/json/ssvc_object_registry.json |
Refreshed generated registry output. |
Review details
Suppressed comments (1)
src/ssvc/utils/namespace_patterns.py:42
- The new lower bound is not covered by the namespace-pattern tests, so the RFC typo could regress without detection. Add a regression case such as
ssvc/x-ato the valid namespace inputs (and keep the generated schema behavior covered through the same pattern).
f'({alnum}){{2,8}})+)*(-[xX](-({alnum}){{1,8}})+)?|[xX](-'
f'({alnum}){{1,8}})+|i-default|i-mingo)'
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Closed
Contributor
Author
|
can @bernhardreiter - take a look at this PR? |
Contributor
|
@sei-vsarvepalli I will take a look (probably later this week) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove typo in the expansion of privateuse from RFC5646.
add the result of the Makefile run
resolve #1239