server config FEATURE public API for hashing a password - #639
Open
niklas-moser wants to merge 1 commit into
Open
server config FEATURE public API for hashing a password#639niklas-moser wants to merge 1 commit into
niklas-moser wants to merge 1 commit into
Conversation
Split the salt generation and the crypt(3) call out of nc_server_config_add_ssh_user_password() into a public nc_server_config_hash_password(). No behaviour change. Lets a caller get just the digest, without building an ietf-netconf-server subtree around it or duplicating the crypt code and its libcrypt dependency.
Roytak
reviewed
Sep 10, 2026
Comment on lines
+501
to
+511
| /** | ||
| * @brief Hashes a clear-text password the way the server stores it in its configuration. | ||
| * | ||
| * Produces a value usable as an 'ietf-ssh-server' hashed-password, that is a crypt(3) SHA-512 | ||
| * digest under a freshly generated random salt ("$6$<salt>$<digest>"). | ||
| * | ||
| * @param[in] password Clear-text password to hash. | ||
| * @param[out] hashed_password Hashed password, memory is allocated and has to be freed by the caller. | ||
| * @return 0 on success, non-zero otherwise. | ||
| */ | ||
| int nc_server_config_hash_password(const char *password, char **hashed_password); |
Contributor
There was a problem hiding this comment.
It would make more sense to me, if this API accepted the whole crypt-hash value (with the $0$) and do something only if the $0$ is present. This would need to be documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the salt generation and the crypt(3) call out of nc_server_config_add_ssh_user_password() into a public nc_server_config_hash_password(). No behaviour change.
Today the logic is only reachable through a function that builds an entire ietf-netconf-server subtree around the result. A caller that wants just the digest has to duplicate the crypt code and take on a libcrypt dependency of its own — which is what CESNET/Netopeer2# would otherwise have to do.
Motivation is: O-RAN WG11 R004, and 3GPP TS 33.117 clause 4.2.3.4.3.1 behind it, don't let a deployment ship clear-text credentials in a datastore, so Netopeer2 has to hash a "$0$" password at commit time