Use ln2 poll session fixes - #1828
Merged
Merged
Conversation
nc_ps_poll() now removes a terminated session from the pollsession and hands its ownership over to the caller, which the server relies on, so require libnetconf2 4.6.0. Also drop the thread count check. MAX_PSPOLL_THREAD_COUNT is gone from libnetconf2, its pollsession queue grows on demand instead, so there is no limit left to check against and the pkg-config variable holding it is not exported anymore either.
A session reported as terminated by nc_ps_poll() is no longer in the pollsession, the poll removed it and handed its ownership over. So nc_ps_del_session() on it fails now and an error was logged for every session that ended normally. np2srv_del_session_cb() is called both for such a session and, on server shutdown, for one that is still in the pollsession and has to be removed from it. Only the caller knows which it is, so it tells the callback with a new parameter.
michalvasko
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CESNET/libnetconf2#637