test: add Pest v1 security test infrastructure - #53
Draft
somethingwithproof wants to merge 9 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Pest v1-based test scaffold for the Cacti audit plugin, focused on source-scanning security checks and basic structural/compatibility validation.
Changes:
- Introduces Pest bootstrap/config plus initial security/compatibility tests under
tests/Security/. - Adds a Composer dev-dependency on Pest to support running the new test suite.
- Adds GitHub metadata workflows/configs (CodeQL + Dependabot).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
tests/Security/SetupStructureTest.php |
Source-level assertions for required setup.php functions/keys. |
tests/Security/PreparedStatementConsistencyTest.php |
Source-scan intended to enforce prepared DB helper usage. |
tests/Security/Php74CompatibilityTest.php |
Source-scan for selected PHP 8+ symbols/operators to preserve PHP 7.4 compatibility. |
tests/Pest.php |
Pest entrypoint requiring the test bootstrap. |
tests/bootstrap.php |
Adds Cacti function stubs to allow tests to run without full Cacti. |
composer.json |
Adds Pest as a dev dependency and dev autoload bootstrap. |
.github/workflows/codeql.yml |
Adds CodeQL workflow (currently JS/TS only; PHP ignored). |
.github/dependabot.yml |
Adds Dependabot updates for npm and GitHub Actions. |
somethingwithproof
marked this pull request as draft
April 11, 2026 00:09
Member
Author
|
Converted to draft to serialize the stack in this repo. Blocked by #51; will un-draft after that merges to avoid cross-PR merge conflicts. |
Add source-scan tests verifying security patterns (prepared statements, output escaping, auth guards, PHP 7.4 compatibility) remain in place across refactors. Tests run with Pest v1 (PHP 7.3+) and stub the Cacti framework so plugins can be tested in isolation. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
…dabot - Throw RuntimeException when realpath/file_get_contents fails (previously silent continue hid unscanned files) - Fix Dependabot ecosystem from npm to composer - Remove committed .omc session artifacts, add .omc/ to .gitignore Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
somethingwithproof
force-pushed
the
test/add-security-test-infrastructure
branch
from
July 14, 2026 10:47
aae35cb to
2af83dd
Compare
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
# Conflicts: # .github/dependabot.yml # .github/workflows/plugin-ci-workflow.yml # .gitignore # audit.php # audit_functions.php # setup.php # tests/Security/SetupStructureTest.php # tests/bootstrap.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
composer install && vendor/bin/pestpasses