Skip to content

[ENG-11998] 5. Show Homepage Banner to Logged-Out Users #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nsemets wants to merge 1 commit into
base: feature/pbs-26-15
Choose a base branch
from
+7 −2
Open

[ENG-11998] 5. Show Homepage Banner to Logged-Out Users #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/features/home/home.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<div class="home-container flex flex-column">
<section class="flex flex-column pt-7 px-3 md:mt-7 md:px-5 xl:flex-row xl:mt-4 xl:px-4">
<osf-scheduled-banner class="xl:mt-8" />

<section class="flex flex-column mt-7 px-3 md:px-5 xl:flex-row xl:mt-4 xl:px-4">
<div
class="flex flex-column align-items-center text-center xl:justify-content-center xl:text-left xl:align-items-start"
>
Expand Down
3 changes: 2 additions & 1 deletion src/app/features/home/home.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { MockComponents, MockProvider } from 'ng-mocks';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { ActivatedRoute, Router } from '@angular/router';

import { ScheduledBannerComponent } from '@osf/core/components/osf-banners/scheduled-banner/scheduled-banner.component';
import { IconComponent } from '@osf/shared/components/icon/icon.component';
import { SearchInputComponent } from '@osf/shared/components/search-input/search-input.component';

Expand All @@ -23,7 +24,7 @@ describe('HomeComponent', () => {
activatedRouteMock = ActivatedRouteMockBuilder.create().build();

TestBed.configureTestingModule({
imports: [HomeComponent, ...MockComponents(SearchInputComponent, IconComponent)],
imports: [HomeComponent, ...MockComponents(SearchInputComponent, IconComponent, ScheduledBannerComponent)],
providers: [provideOSFCore(), MockProvider(Router, routerMock), MockProvider(ActivatedRoute, activatedRouteMock)],
});

Expand Down
2 changes: 2 additions & 0 deletions src/app/features/home/home.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { Component, inject } from '@angular/core';
import { FormControl } from '@angular/forms';
import { Router, RouterLink } from '@angular/router';

import { ScheduledBannerComponent } from '@osf/core/components/osf-banners/scheduled-banner/scheduled-banner.component';
import { IconComponent } from '@osf/shared/components/icon/icon.component';
import { SearchInputComponent } from '@osf/shared/components/search-input/search-input.component';

Expand All @@ -19,6 +20,7 @@ import { INTEGRATION_ICONS, SLIDES } from './constants/data';
Carousel,
Button,
SearchInputComponent,
ScheduledBannerComponent,
IconComponent,
NgOptimizedImage,
NgTemplateOutlet,
Expand Down
Loading