Skip to content

fix(eth): respect tombstone - #7537

Open
LesnyRumcajs wants to merge 1 commit into
eth-get-storage-at-fast-trackfrom
pay-respect-to-tombstone
Open

fix(eth): respect tombstone#7537
LesnyRumcajs wants to merge 1 commit into
eth-get-storage-at-fast-trackfrom
pay-respect-to-tombstone

Conversation

@LesnyRumcajs

@LesnyRumcajs LesnyRumcajs commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary of changes

Changes introduced in this pull request:

  • we didn't respect the tombstone in some of the eth methods, e.g., on a tombstoned contract we should return nonce zero and not what was there before it got yanked.
  • matches Lotus (it was a bug only on our end) and reth (for the trace diff that is not there in Lotus)

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • This pull request is based on an issue that a maintainer has accepted (see Before Opening a Pull Request).
  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 19408620-aeb8-413d-a575-087ee8c5b395

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@LesnyRumcajs
LesnyRumcajs force-pushed the pay-respect-to-tombstone branch from 0cb9221 to b6e52b0 Compare August 24, 2026 12:50
@LesnyRumcajs
LesnyRumcajs marked this pull request as ready for review August 24, 2026 12:59
@LesnyRumcajs
LesnyRumcajs requested a review from a team as a code owner August 24, 2026 12:59
@LesnyRumcajs
LesnyRumcajs requested review from EclesioMeloJunior and sudo-shashank and removed request for a team August 24, 2026 12:59
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (eth-get-storage-at-fast-track@c36fd82). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/rpc/methods/eth/utils.rs 78.57% 0 Missing and 3 partials ⚠️
src/rpc/methods/eth/trace/test_helpers.rs 91.30% 0 Missing and 2 partials ⚠️
src/rpc/methods/eth.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/rpc/methods/eth/trace/state_diff.rs 88.21% <100.00%> (ø)
src/state_manager/message_simulation.rs 75.86% <100.00%> (ø)
src/rpc/methods/eth.rs 69.38% <0.00%> (ø)
src/rpc/methods/eth/trace/test_helpers.rs 86.79% <91.30%> (ø)
src/rpc/methods/eth/utils.rs 89.64% <78.57%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36fd82...051962a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs LesnyRumcajs added the RPC requires calibnet RPC checks to run on CI label Aug 24, 2026
@LesnyRumcajs
LesnyRumcajs force-pushed the pay-respect-to-tombstone branch from b6e52b0 to 051962a Compare August 24, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants