Enhance Android build with diagnostics and refactor installer logic - #27
Open
uurcan7 wants to merge 5 commits into
Open
Enhance Android build with diagnostics and refactor installer logic#27uurcan7 wants to merge 5 commits into
uurcan7 wants to merge 5 commits into
Conversation
Removed copyright notice and added new constants for boot script handling. by @AntiOblivionis and @LIghtJUNction
Co-authored-by: uurcan7 <79050542+uurcan7@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ual-build Add manually triggered Android build workflow
There was a problem hiding this comment.
🟡 Changes recommended
There are functional issues in the installer update gating (script update constant vs. versionCode) and in boot animation PID parsing that can break boot-state detection.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds runtime diagnostics and a user-configurable “exit delay” for LiveBoot’s boot shutdown sequence, refactors installer boot-script logic (including more robust display dimension detection), and introduces a GitHub Actions workflow for manual Android builds.
Changes:
- Add a new “Exit delay” setting (persisted as
suicide_delay_ms) and pass it through to the root runner via launch-script args. - Add a diagnostic log facility in
Runnerto help debug boot/exit conditions and line handling. - Refactor
Installerscript generation (delayed boot scripts) and improve screen-dimension detection; add a manual Android build workflow.
File summaries
| File | Description |
|---|---|
| liveBootAni2/src/main/res/values/strings.xml | Adds UI strings for the new “Exit delay” setting. |
| liveBootAni2/src/main/java/eu/chainfire/liveboot/shell/Runner.java | Adds diagnostic logging, updated boot completion heuristics, and applies the new exit delay option. |
| liveBootAni2/src/main/java/eu/chainfire/liveboot/SettingsFragment.java | Adds an EditTextPreference with normalization/clamping for the exit delay setting. |
| liveBootAni2/src/main/java/eu/chainfire/liveboot/Settings.java | Adds persisted setting key/value for suicide_delay_ms. |
| liveBootAni2/src/main/java/eu/chainfire/liveboot/Installer.java | Refactors delayed boot script creation, updates install-needed checks, and improves screen dimension detection. |
| .github/workflows/manual-build.yml | Adds a workflow_dispatch-driven build that uploads APK artifacts. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| private static final int LAST_SCRIPT_UPDATE = 188; | ||
|
|
||
| private static final int LAST_SCRIPT_UPDATE = 195; |
Comment on lines
+336
to
+349
| private Integer getPidFromPsLine(String line) { | ||
| if (line == null) return null; | ||
| String[] parts = line.trim().split(" +"); | ||
| for (String part : parts) { | ||
| try { | ||
| int pid = Integer.valueOf(part, 10); | ||
| if (pid > 1) { | ||
| return pid; | ||
| } | ||
| } catch (Exception e) { | ||
| } | ||
| } | ||
| return null; | ||
| } |
| * along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| package eu.chainfire.liveboot; |
Comment on lines
+223
to
+226
| if (mDiagStream != null) { | ||
| mDiagStream.write(line.getBytes()); | ||
| mDiagStream.flush(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.