Enhance credential store tests and functionality (AST-178846) - #1572
Merged
Merged
Conversation
- Updated `TestStoreRequiredRoundTripKeepsValueOutOfYAML` to verify that the credential value is not written to the YAML file. - Added new tests: - `TestStoreAndClearAutoTouchConfigFileMtime` to ensure the config file's modification time is updated after storing or clearing credentials. - `TestStoreFailureDoesNotTouchConfigFile` to confirm that a failed store operation does not create a config file. - `TestTouchConfigFileToleratesUnusablePaths` to handle various invalid paths gracefully. - Modified `Store` and `Clear` methods in the resolver to touch the config file's mtime upon successful operations, ensuring consumers are notified of changes.
cx-prathmesh-borle
changed the title
cx-umesh-waghode
approved these changes
Sep 11, 2026
cx-umesh-waghode
left a comment
cx-umesh-waghode
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. confirmed test results with dev.
cx-rahul-pidde
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestStoreRequiredRoundTripKeepsValueOutOfYAMLto verify that the credential value is not written to the YAML file.TestStoreAndClearAutoTouchConfigFileMtimeto ensure the config file's modification time is updated after storing or clearing credentials.TestStoreFailureDoesNotTouchConfigFileto confirm that a failed store operation does not create a config file.TestTouchConfigFileToleratesUnusablePathsto handle various invalid paths gracefully.StoreandClearmethods in the resolver to touch the config file's mtime upon successful operations, ensuring consumers are notified of changes.By submitting this pull request, you agree to the terms within the Checkmarx Code of Conduct. Please review the contributing guidelines for guidance on creating high-quality pull requests.
Description
Please provide a summary of the changes and the related issue. Include relevant motivation and context.
Type of Change
Related Issues
Link any related issues or tickets.
Checklist
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Add any other relevant information.