Udp.Code.Synchronize with cloud - #735
Open
alexander-b-clean wants to merge 2 commits into
Open
alexander-b-clean wants to merge 2 commits into
alexander-b-clean wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A critical race can cause duplicate work and conflicting progress updates.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Refactors cloud synchronization to share progress handling between synchronous and background execution.
Changes:
- Initializes persisted sync progress.
- Uses the step-based workflow for synchronous synchronization.
- Preserves reload status during finalization.
File summaries
| File | Summary |
|---|---|
lib/CleantalkSP/SpbctWP/Sync.php |
Updates synchronization progress and execution flow. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if ( ! empty($progress['in_progress']) ) { | ||
| self::saveProgress(self::getDefaultProgress()); | ||
| } | ||
| self::initializeProgress(); |
svedge
requested changes
Sep 14, 2026
svedge
left a comment
svedge
left a comment
There was a problem hiding this comment.
We need to take a closer look at the task. This PR does not reflect the conditions of the task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/42930