Match Mintlify accordion styling - #338
Open
Blargian wants to merge 20 commits into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 736724b. Configure here.
Keep scoped remote previews independent of the reduced public asset output while preserving build-time icon embedding.
Keep hidden routes in the generated navigation metadata for rail selection while omitting them from rendered navigation.
# Conflicts: # package.json # src/lib/sidebar-lazy.ts
|
🕵
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the accordion and code-block styling, spacing, and grouped disclosure behavior used by the existing Mintlify documentation, reduces the height of the sidebar language selector, removes delayed external icon requests from cards and tabs, and enables Vercel Speed Insights across the site.
Card and tab icons are resolved from local assets at build time, and tab triggers are rendered in the initial HTML so their icons and labels appear with the rest of the page. Remote-slice previews include the shared ClickHouse logo and resolve build assets from the project root, which keeps the same icon pipeline working after Astro bundles its prerender code. Public image trees are copied from their real source directories rather than through repository symlinks so Vercel checkouts produce the same assets as local builds.
The generated sidebar now preserves page-level icon metadata and renders named icons inline from bundled Iconify sets. Local SVG and image icons are also embedded into the initial HTML as data URLs, avoiding delayed sidebar icon requests. Repository-owned icons resolve directly from their source tree so scoped remote previews do not need to copy the complete public image tree. Pages marked
hidden: trueremain available as route-selection metadata but are omitted from rendered navigation, preserving the correct sidebar context on their published URLs.The homepage MCP link now uses the same embedded SVG and 14px dimensions as the “Set up docs MCP” page action instead of recoloring the asset as a CSS mask.
Homepage links to
index.mdxpages now use Nimbus's canonical directory routes instead of Mintlify's additional/indexaliases, preventing 404s on Vercel for Core concepts and the other affected cards.The shared Astro layout now renders the
@vercel/speed-insightsAstro component, covering documentation pages, the homepage, and generated error pages.Code blocks now use Mintlify's compact type size, line height, padding, border radius, dark surface, and always-visible copy control. Runnable SQL blocks share that chrome and attach their action bar directly to the code block without a gap.
Accordions inside an
AccordionGroupnow behave as a mutually exclusive set: opening one closes the previously open item, while selecting the open item can close the entire group. Standalone accordions remain independent.Sidebar disclosure state is initialized once from the first rendered page. From then on, navigation restores the exact user-controlled open/closed state; selecting a page never opens or closes any group.
Validated with:
pnpm exec astro check(0 errors)clickhouse-privateremote-preview path (365 pages)/docs/concepts/core-conceptsand the canonical Core concepts route is generatedgit diff --checkChangelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Match Mintlify accordion styling and grouped disclosure behavior, preserve sidebar disclosure state across navigation, match code-block styling, render documentation and sidebar icons from local build assets, and enable Vercel Speed Insights.