chore: pin memtrack 1.5.1 - #541
Merged
Merged
Conversation
Picks up the lifecycle and syscall hooks attaching without perf_event_open, and the mmap/munmap/brk artifact variants kept as deprecated instead of dropped. Refs COD-3543 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
adriencaccia
marked this pull request as ready for review
September 16, 2026 20:30
 |
Merging this PR will not alter performance
|
moha-bekh
added a commit
that referenced
this pull request
Sep 17, 2026
…ck-musl One conflict, in `src/binary_pins.rs`, resolved in favour of this branch. main's `chore: pin memtrack 1.5.1 (#541)` bumps the `MEMTRACK_INSTALLER` version and hash; this branch deletes that pin, along with `EXEC_HARNESS_INSTALLER` and the whole download machinery, because memtrack and exec-harness are linked into the `codspeed` binary and reached as hidden subcommands. There is nothing left to download, so there is no version to bump. Kept the deletion. Nothing else refers to `MEMTRACK_INSTALLER`, `EXEC_HARNESS_INSTALLER`, `MEMTRACK_VERSION` or `EXEC_HARNESS_VERSION` after the merge. `binary_pins.rs` keeps the valgrind .deb and the mongo-tracer installer, both still downloaded. main also brings the valgrind build-from-source work and the 5.3.1 / memtrack 1.5.1 releases, which merged cleanly. `cargo fmt --check` and `cargo clippy --workspace --all-targets -- -D warnings` are clean on the result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the runner at memtrack v1.5.1, which attaches the lifecycle and syscall hooks without
perf_event_openand keepsmmap/munmap/brkas deprecated artifact variants instead of dropping them.Hash verified against the published installer with
GITHUB_ACTIONS=true cargo test all_pinned.Refs COD-3543 — that issue also covers the runner patch release this unblocks.