-
-
Notifications
You must be signed in to change notification settings - Fork 327
London | 26-ITP-May | Zadri Abdule | Sprint 2 | Exercises #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zadri415
wants to merge
12
commits into
CodeYourFuture:main
Choose a base branch
from
Zadri415:sprint-2-only
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
23f1985
chore(sprint-2): create clean branch with Sprint-2 files
Zadri415 e1e9072
Update contains.test.js
Zadri415 28477c2
Update querystring.js
Zadri415 fb64876
Update invert.js
Zadri415 a9c191f
Update tally.js
Zadri415 30719f0
Update invert.js
Zadri415 d58a092
Update contains.test.js
Zadri415 f34837d
Update invert.js
Zadri415 5a61bb3
Update tally.js
Zadri415 6895740
Update invert.js
Zadri415 b971c94
Merge branch 'CodeYourFuture:main' into sprint-2-only
Zadri415 a3dea39
Update tally.js
Zadri415 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,8 @@ | ||
| function contains() {} | ||
| function contains(obj, prop) { | ||
| if (typeof obj !== "object" || obj === null) { | ||
| return false; | ||
| } | ||
| return obj.hasOwnProperty(prop); | ||
| } | ||
|
|
||
| module.exports = contains; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,17 @@ | ||
| function createLookup() { | ||
| // implementation here | ||
| function createLookup(countryCurrencyPairs) { | ||
| let lookUp = {}; | ||
| if (!Array.isArray(countryCurrencyPairs)) { | ||
| throw new Error("Input must be an array of arrays"); | ||
| } | ||
| countryCurrencyPairs.forEach(pair => { | ||
| if (Array.isArray(pair) && pair.length === 2) { | ||
| lookUp[pair[0]] = pair[1]; | ||
| } else { | ||
| throw new Error("Each element of the input array must be an array of two elements"); | ||
| } | ||
| }); | ||
|
|
||
| return lookUp; | ||
| } | ||
|
|
||
| module.exports = createLookup; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,30 @@ | ||
| function parseQueryString(queryString) { | ||
| const queryParams = {}; | ||
| if (queryString.length === 0) { | ||
| return queryParams; | ||
| const params = {}; | ||
| if (!queryString) { | ||
| return params; | ||
| } | ||
| const keyValuePairs = queryString.split("&"); | ||
|
|
||
| for (const pair of keyValuePairs) { | ||
| const [key, value] = pair.split("="); | ||
| queryParams[key] = value; | ||
| } | ||
| const pairs = queryString.split("&"); | ||
| for (const pair of pairs) { | ||
| if (!pair) continue; // Ignore empty key-value pairs | ||
|
|
||
| const [key, ...valueParts] = pair.split("="); | ||
| const value = valueParts.join("="); // Join back in case value contains '=' | ||
|
|
||
| return queryParams; | ||
| const decodedKey = decodeURIComponent(key.replace(/\+/g, " ")); | ||
| const decodedValue = decodeURIComponent(value.replace(/\+/g, " ")); | ||
|
|
||
| if (params.hasOwnProperty(decodedKey)) { | ||
| if (Array.isArray(params[decodedKey])) { | ||
| params[decodedKey].push(decodedValue); | ||
| } else { | ||
| params[decodedKey] = [params[decodedKey], decodedValue]; | ||
| } | ||
| } else { | ||
| params[decodedKey] = decodedValue; | ||
| } | ||
| } | ||
| return params; | ||
| } | ||
|
|
||
| module.exports = parseQueryString; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,15 @@ | ||
| function tally() {} | ||
| function tally(items) { | ||
| if (!Array.isArray(items)) { | ||
| throw new Error('tally expects an array'); | ||
| } | ||
| const counts = Object.create(null); | ||
| for (const item of items) { | ||
|
|
||
| // JS runtime implicitly converts 'item' to a string key safely | ||
| counts[item] = (counts[item] || 0) + 1; | ||
| } | ||
|
|
||
| return counts; | ||
| } | ||
|
|
||
| module.exports = tally; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file basically remain unchanged since my previous review. The comments I left on this file still hold. The most recent commit (30719f0) that says "Update invert.js" only removed an empty line from the file: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| const invert = require('./invert'); | ||
|
|
||
| test('inverts a single key/value pair', () => { | ||
| expect(invert({ a: 1 })).toEqual({ '1': 'a' }); | ||
| }); | ||
|
|
||
| test('inverts multiple pairs', () => { | ||
| expect(invert({ a: 1, b: 2 })).toEqual({ '1': 'a', '2': 'b' }); | ||
| }); | ||
|
|
||
| test('string values become keys', () => { | ||
| expect(invert({ a: 'x', b: 'y' })).toEqual({ x: 'a', y: 'b' }); | ||
| }); | ||
|
|
||
| test('collects multiple keys that share the same value', () => { | ||
| const input = { a: 1, b: 1, c: 2 }; | ||
| const actual = invert(input); | ||
| expect(actual["1"]).toEqual(expect.arrayContaining(["a", "b"])); | ||
| expect(actual["2"]).toBe("c"); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.