London | 26-ITP-May | Rizqah Popoola | Sprint 3 | Alarm Clock - #1357
Open
risikatpopoola wants to merge 5 commits into
Open
London | 26-ITP-May | Rizqah Popoola | Sprint 3 | Alarm Clock#1357risikatpopoola wants to merge 5 commits into
risikatpopoola wants to merge 5 commits into
Conversation
risikatpopoola
added
🏕 Priority Mandatory
abdishakoor-dev
changed the title
cjyuan
reviewed
Aug 8, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
-
If a user enters a time and then clicks the "Set Alarm" button multiple times, the countdown clock will not display properly. Could you fix the issue?
-
Currently when starting a new countdown, the application does not always return to a clean initial state, which can lead to inconsistent behaviour between runs.
Note: a user may not click the "Stop" button first before starting a new count down.
cjyuan
added
Reviewed
risikatpopoola
added
Needs Review
cjyuan
added
Reviewed
risikatpopoola
added
Needs Review
cjyuan
reviewed
Aug 13, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
When input is 1, the alarm is played one second later -- an expected behavior.
However, when input is 0, the alarm is also played one second later (instead of being played immediately).
Could you make the app's behaviour more consistent?
cjyuan
added
Reviewed
risikatpopoola
added
Needs Review
cjyuan
reviewed
Aug 15, 2026
| const seconds = String(totalSeconds % 60).padStart(2, "0"); | ||
|
|
||
| timeRemaining.innerText = `Time Remaining: ${minutes}:${seconds}`; | ||
| if (alarmInput.value === "" || totalSeconds < 0 || !Number.isInteger(0)) { |
Contributor
There was a problem hiding this comment.
- The 3rd condition is always
falseeven iftotalSecondsisNaN.
Comment on lines
+32
to
38
| timer = setInterval(() => { | ||
| if (totalSeconds <= 0) { | ||
| clearInterval(timer); | ||
| playAlarm(); | ||
| } | ||
| updateTime(totalSeconds--); | ||
| }, 1000); |
Contributor
There was a problem hiding this comment.
With this change, there will always be a one second delay before the alarm sound.
Could you find a way to get rid the one second delay?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist