London | 26-ITP-May | Anita Amirhaeri | Sprint 3 | Alarm Clock - #1388
Open
anitahy73 wants to merge 3 commits into
Open
London | 26-ITP-May | Anita Amirhaeri | Sprint 3 | Alarm Clock#1388anitahy73 wants to merge 3 commits into
anitahy73 wants to merge 3 commits into
Conversation
Implemented alarm countdown functionality with display update.
Updated the HTML structure and title for the alarm clock app.
anitahy73
added
📅 Sprint 3
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Aug 8, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
A few observations from testing:
- The timer accepts negative and decimal values. What should happen when such values are entered?
- When the alarm is set multiple times, could this leave multiple intervals running or put the application into an unexpected state?
- What happens to the active countdown when the user stops the alarm before it reaches 0?
hey-hammad
added
Reviewed
Sanitize input and handle negative values in alarm clock.
anitahy73
added
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Aug 15, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Nice effort, however multiple code quality and validation issues needs to be addressed. Thanks
|
|
||
| function setAlarm() { | ||
| // sanitize input: convert to number, floor to integer seconds, clamp to >= 0 | ||
| let timeInput = Math.floor(Number(input.value) || 0); |
There was a problem hiding this comment.
What would happen If I set the alarm for unexpected values such as an empty string or 0?
|
|
||
| // handle negative input explicitly | ||
| const rawValue = Number(input.value); | ||
| if (rawValue < 0) { |
There was a problem hiding this comment.
Since we've already type casted and validated the input above is there a need to do this here again?
| let minutes = Math.floor(timeInput / 60); | ||
| let seconds = timeInput % 60; | ||
|
|
||
| minutes = minutes.toString().padStart(2, "0"); |
There was a problem hiding this comment.
the formatting logic is duplicated, can we extract out this logic into a function to remove code duplication?
hey-hammad
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Sprint 3 | Alarm Clock
Questions