London | 26-ITP-May | Anita Amirhaeri | Sprint 2 | Module-data-group - #1390
Open
anitahy73 wants to merge 19 commits into
Open
London | 26-ITP-May | Anita Amirhaeri | Sprint 2 | Module-data-group#1390anitahy73 wants to merge 19 commits into
anitahy73 wants to merge 19 commits into
Conversation
Updated recipe logging to display ingredients on separate lines.
Implemented the createLookup function to build a lookup object from country-currency pairs.
Refactor parseQueryString to handle empty pairs and decode keys/values.
Removed optional test for handling identical keys in query strings.
anitahy73
added
📅 Sprint 2
cjyuan
reviewed
Aug 10, 2026
cjyuan
added
Reviewed
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Contributor
|
You might have accidently "saved" |
anitahy73
added
Needs Review
cjyuan
reviewed
Aug 14, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good.
Could you also update contains.test.js and lookup.test.js, and tally.test.js?
cjyuan
removed
the
Needs Review
cjyuan
added
the
Reviewed
Added tests for the 'contains' function to validate behavior with various inputs, including empty objects, existing properties, non-existent properties, and invalid inputs.
Added input validation for countryCurrencyPairs and improved error handling.
Added tests for createLookup function to verify correct handling of valid pairs, empty input, and malformed pairs.
anitahy73
added
Needs Review
cjyuan
reviewed
Aug 16, 2026
Comment on lines
+35
to
+36
| expect(tally(["a"])).toEqual({ a: 1 }); | ||
| expect(tally(["a", "a", "a"]).a).toBe(3); |
Contributor
There was a problem hiding this comment.
Could you research the trade-off between the first and the 2nd approaches to check if the function counts duplicates correctly?
| }); | ||
|
|
||
| test("invalid inputs (arrays, null, non-objects) return false", () => { | ||
| expect(contains([], "0")).toBe(false); |
Contributor
There was a problem hiding this comment.
Array in JS is also an object, but "0" is not a key of [].
A function that fails to check if the first argument is an array could also return false simply because "0" is not a key of an empty array. To properly test if the function could return false when the first argument is an array, we should use a non-empty array, and then specify a key which the array has as the 2nd argument.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Sprint 2 | Module-data-group
Questions