Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Implement alarmclock - #1412
Open
KhotKeys wants to merge 1 commit into
Open
Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Implement alarmclock#1412KhotKeys wants to merge 1 commit into
KhotKeys wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
KhotKeys
force-pushed
the
sprint-3-alarmclock
branch
from
August 8, 2026 17:42
39ba3d8 to
e929c4a
Compare
KhotKeys
changed the title
This comment has been minimized.
This comment has been minimized.
KhotKeys
changed the title
KhotKeys
added
📅 Sprint 3
selyafi
reviewed
Aug 12, 2026
| @@ -1,4 +1,24 @@ | |||
| function setAlarm() {} | |||
| function setAlarm() { | |||
| let seconds = parseInt(document.getElementById("alarmSet").value, 10); | |||
There was a problem hiding this comment.
What does parseInt("", 10) give you? Try clicking Set Alarm with the box empty and watch the heading and then think about whether seconds <= 0 on line 16 will ever be true.
|
|
||
| heading.innerText = formatTime(seconds); | ||
|
|
||
| const timer = setInterval(() => { |
There was a problem hiding this comment.
Set a 10 second alarm and then few seconds later set a 30 second one without refreshing. Watch the heading closely. What is happening, and what does const timer being declared inside setAlarm have to do with it?
| let seconds = parseInt(document.getElementById("alarmSet").value, 10); | ||
| const heading = document.getElementById("timeRemaining"); | ||
|
|
||
| function formatTime(s) { |
There was a problem hiding this comment.
formatTime gets rebuilt every time setAlarm runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist