London | 26-ITP-May | Ebrahim Moqbel | sprint 2 | course work - #1420
Open
Ebrahim-Moqbel wants to merge 4 commits into
Open
London | 26-ITP-May | Ebrahim Moqbel | sprint 2 | course work#1420Ebrahim-Moqbel wants to merge 4 commits into
Ebrahim-Moqbel wants to merge 4 commits into
Conversation
Ebrahim-Moqbel
added
📅 Sprint 2
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
Aug 12, 2026
Comment on lines
+2
to
+9
| describe('createLookup',()=>{ | ||
| test("creates a country currency code lookup for multiple codes",()=>{ | ||
| const arrayInput=[['US', 'USD'], ['CA', 'CAD']] | ||
| expect(createLookup(arrayInput)).toEqual({US: 'USD',CA:"CAD"}) | ||
| }); | ||
|
|
||
|
|
||
| }) |
There was a problem hiding this comment.
With Test Driven Development (TDD) I would want maybe another test to come before this one. A smaller test with a simpler and different input to prove that the test was built up carefully and that the function can handle different inputs and is not hard coded
Author
There was a problem hiding this comment.
Thank you Poonam-raj,
I will be considering building up my tests gradually next time
Poonam-raj
reviewed
Aug 12, 2026
Comment on lines
-23
to
-24
| expect(parseQueryString("key")).toEqual({ key: "" }); | ||
| expect(parseQueryString("key=")).toEqual({ key: "" }); |
There was a problem hiding this comment.
What was your thinking when removing these two test assertions?
Author
There was a problem hiding this comment.
the test was throwing an error of this two cases. I deleted them and forget to write them back.
Poonam-raj
reviewed
Aug 12, 2026
| // When passed to tally | ||
| // Then it should throw an error | ||
| test('tally with invalid input like a string, throw an error', ()=>{ | ||
| expect(()=>tally("")).toThrow(Error) |
There was a problem hiding this comment.
For accuracy in the code, it makes sense to expect a TypeError here as that's the behaviour you've created in the code.
Author
There was a problem hiding this comment.
thank you will be updating this accordingly
Poonam-raj
reviewed
Aug 12, 2026
Comment on lines
+26
to
+28
| // It returns an array of [key,value] pairs as two elements array and was used to return the object into enumerable array | ||
| // d) Explain why the current return value is different from the target output | ||
|
|
||
| // the function contain a bug as the dot notation here was overwriting the object in the loop also the return is not swapping the input |
Poonam-raj
reviewed
Aug 12, 2026
Comment on lines
+31
to
+41
| function invert(obj) { | ||
|
|
||
|
|
||
| const invertedObj = {}; | ||
|
|
||
| for (const [key, value] of Object.entries(obj)) { | ||
| invertedObj[value] = key; | ||
| } | ||
|
|
||
| return invertedObj; | ||
| } |
Poonam-raj
reviewed
Aug 12, 2026
Poonam-raj
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
completed the debug , implement and interpret file buy building the functions and interpreting the requirements of the test cases.
Questions
N/A