London | 26-ITP-May | Edina Kurdi | Sprint 3 | Alarm clock - #1430
Open
edinakurdi wants to merge 10 commits into
Open
London | 26-ITP-May | Edina Kurdi | Sprint 3 | Alarm clock#1430edinakurdi wants to merge 10 commits into
edinakurdi wants to merge 10 commits into
Conversation
edinakurdi
added
🏕 Priority Mandatory
9 tasks
cjyuan
reviewed
Aug 14, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Currently when starting a new countdown, the application does not always return to a clean initial state, which can lead to inconsistent behaviour between runs.
Note: a user may not click the "Stop" button first before starting a new count down.
Comment on lines
+14
to
+16
| const minutes = String(Math.floor(remainingSeconds / 60)).padStart(2, "0"); | ||
| const seconds = String(remainingSeconds - minutes * 60).padStart(2, "0"); | ||
| timeRemaining.textContent = `Time Remaining: ${minutes}:${seconds}`; |
Contributor
There was a problem hiding this comment.
Code on lines 7-10 is very similar to those on lines 14-16.
To adhere to the DRY principle in programming, could you refactor the repeated code into a reusable function?
Comment on lines
+2
to
+4
| const timeInput = document.getElementById("alarmSet"); | ||
| // console.log(timeInput.value); | ||
| let remainingSeconds = timeInput.value; |
Contributor
There was a problem hiding this comment.
-
Using raw input without proper validation is a dangerous practice. For number, we should consider
- What type of number should it be? Integer or floating point number?
- What range of numbers are acceptable?
- What kind of invalid value should also be rejected?
-
Unused code and comments should be removed to keep the code clean.
Author
There was a problem hiding this comment.
Thank you for pointing this out.
Code is updated accordingly.
cjyuan
added
Reviewed
…mbers and empty strings
edinakurdi
added
Needs Review
cjyuan
reviewed
Aug 14, 2026
| const seconds = String(remainingSeconds - minutes * 60).padStart(2, "0"); | ||
|
|
||
| timeRemaining.textContent = `Time Remaining: ${minutes}:${seconds}`; | ||
| timeRemaining.textContent = `Time Remaining: ${timeConvert(remainingSeconds)}`; |
Contributor
There was a problem hiding this comment.
Could also consider turning this statement into a function:
- Same code is used on line 27
displayTime(remainingSeconds)is probably more readable
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist