Skip to content

London | 26-ITP-May | Gideon Defar | Sprint 2 | Coursework - #1431

Open
gideondefar wants to merge 4 commits into
CodeYourFuture:mainfrom
gideondefar:feature/sprint-2-coursework
Open

London | 26-ITP-May | Gideon Defar | Sprint 2 | Coursework#1431
gideondefar wants to merge 4 commits into
CodeYourFuture:mainfrom
gideondefar:feature/sprint-2-coursework

Conversation

@gideondefar

@gideondefar gideondefar commented Aug 14, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed Data Groups Sprint 2 exercises.

  • Fixed bugs in Address, Author, and Recipe.
  • Implemented contains, lookup, querystring, and tally functions with tests.
  • Completed the invert interpretation exercise with tests.
  • Tested the changes to verify the expected behaviour.

@gideondefar gideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module Core This is a core task and should be completed by all trainees labels Aug 14, 2026
cjyuan
cjyuan reviewed Aug 14, 2026
View reviewed changes

@cjyuan cjyuan left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great.

Could you also implement the Jest tests in contains.test.js, lookup.test.js, and tally.test.js?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 14, 2026
@gideondefar gideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 14, 2026
@gideondefar

gideondefar commented Aug 14, 2026

Copy link
Copy Markdown
Author

Code looks great.

Could you also implement the Jest tests in contains.test.js, lookup.test.js, and tally.test.js?

I forgot to push that's why.

cjyuan
cjyuan reviewed Aug 14, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Core This is a core task and should be completed by all trainees Module-Data-Groups The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gideondefar @cjyuan