Skip to content

London | 26-ITP-MAY | Ebrahim Moqbel | Sprint 2 | Form Controls #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ebrahim-Moqbel wants to merge 11 commits into from
Closed

London | 26-ITP-MAY | Ebrahim Moqbel | Sprint 2 | Form Controls #1119

Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4032809
A reason for me to join CYF
Ebrahim-Moqbel Jan 13, 2026
50fcc71
Reson
Ebrahim-Moqbel Jan 13, 2026
749a886
What is Git and why is it being used?
Ebrahim-Moqbel Jan 13, 2026
0173fea
Article on the purpos of git
Ebrahim-Moqbel Jan 13, 2026
47925f5
Merge branch 'CodeYourFuture:main' into main
Ebrahim-Moqbel Jan 25, 2026
dc50152
Merge branch 'CodeYourFuture:main' into main
Ebrahim-Moqbel Feb 2, 2026
84147a6
form control
Ebrahim-Moqbel Feb 2, 2026
280c8fd
size div
Ebrahim-Moqbel Feb 2, 2026
270dbee
unwanted article deleted
Ebrahim-Moqbel Feb 2, 2026
697f95f
labelling the T-shirt size and chaninging the color section to be rec…
Ebrahim-Moqbel Feb 7, 2026
a008f20
I placed the radio buttom name after the radio button input fot the …
Ebrahim-Moqbel Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 48 additions & 7 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,57 @@
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<form>
<section>

<div>
<label for="name"> Name*: </label>
<input type="text" id="name" name="name" required minlength="2">
</div>

<div>
<label for="email">Email*:</label>
<input type="email" id="email" name="email" required>
</div>


<fieldset>
<legend >t-shirt Color</legend>
<div>
<label for="black" required>Black</label>

@jenny-alexander jenny-alexander Feb 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required attribute only applies to form input elements, not labels.

<input type="radio" id="black" name="t-shirt-color" value="black">

@jenny-alexander jenny-alexander Feb 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the radio button name is placed before the radio button input. For better UX, try placing the radio button before the label.

</div>
<div>
<label for="red">Red </label>
<input type="radio" id="red" name="t-shirt-color" value="red">
</div>
<div>
<label for="green">Green </label>
<input type="radio" id="green" name="t-shirt-color" value="green">
</div>
</fieldset>


<div>
<label for="T-shirt-size" >T-Shirt Size</label>

@jenny-alexander jenny-alexander Feb 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The for attribute must exactly match the id attribute (case-sensitive). These don't match, so the label won't be properly associated with the select element.

<select name="T-shirtSize" id="T-shirtSize" required>
<option value="XS">XS</option>
<option label="S" value="S">S</option>
<option label="M" value="M">M</option>
<option label="L" value="L">L</option>
<option label="XL" value="XL">XL</option>
<option label="XXL" value="XXL">XXL</option>
</select>
</div>
<div>
<button type="submit">Place your order</button>
</div>
</section>
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>

<p>By Ebraim Moqbel</p>
</footer>
</body>
</html>